Skip to content

[CP Staging] Block negative sign for IOU expense inline editing in IOU report #90882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 2 commits into from
May 18, 2026
Merged

[CP Staging] Block negative sign for IOU expense inline editing in IOU report #90882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9451328
Pass report and policy props to TotalCell to fix negative sign in IOU…
MelvinBot May 16, 2026
eb27a8d
Remove report prop from TotalCell in TransactionItemRowNarrow
MelvinBot May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/components/TransactionItemRow/DataCells/TotalCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,17 @@ import {parseFloatAnyLocale, roundToTwoDecimalPlaces} from '@libs/NumberUtils';
import {getTransactionDetails, isInvoiceReport, shouldEnableNegative} from '@libs/ReportUtils';
import {getCurrency as getTransactionCurrency, isDeletedTransaction, isExpenseUnreported, isScanning} from '@libs/TransactionUtils';
import CONST from '@src/CONST';
import type {Policy, Report} from '@src/types/onyx';
import type TransactionDataCellProps from './TransactionDataCellProps';

type TotalCellProps = TransactionDataCellProps & EditableProps<number>;
type TotalCellProps = TransactionDataCellProps &
EditableProps<number> & {
/** Report passed explicitly (used in IOU report view where transactionItem.report may be undefined) */
report?: Report;

/** Policy passed explicitly (used in IOU report view where transactionItem.policy may be undefined) */
policy?: Policy;
};
type TransactionItem = TransactionDataCellProps['transactionItem'];

function getTransactionItemIouType(transactionItem: TransactionItem) {
Expand All @@ -28,7 +36,7 @@ function getTransactionItemIouType(transactionItem: TransactionItem) {
return isSplitTransaction ? CONST.IOU.TYPE.SPLIT : CONST.IOU.TYPE.SUBMIT;
}

function TotalCell({shouldShowTooltip, transactionItem, canEdit, onSave}: TotalCellProps) {
function TotalCell({shouldShowTooltip, transactionItem, canEdit, onSave, report, policy}: TotalCellProps) {
const styles = useThemeStyles();
const {translate, preferredLocale} = useLocalize();
const {convertToDisplayString} = useCurrencyListActions();
Expand All @@ -41,10 +49,12 @@ function TotalCell({shouldShowTooltip, transactionItem, canEdit, onSave}: TotalC
amountToDisplay = translate('iou.receiptStatusTitle');
}

const iouType = getTransactionItemIouType(transactionItem);
const effectiveReport = report ?? transactionItem.report;
const effectivePolicy = policy ?? transactionItem.policy;
const iouType = getTransactionItemIouType({...transactionItem, report: effectiveReport});
const isSplitBill = iouType === CONST.IOU.TYPE.SPLIT;
const isUnreportedExpense = isExpenseUnreported(transactionItem);
const allowNegative = isUnreportedExpense || shouldEnableNegative(transactionItem.report, transactionItem.policy, iouType, transactionItem.participants);
const allowNegative = isUnreportedExpense || shouldEnableNegative(effectiveReport, effectivePolicy, iouType, transactionItem.participants);

const absoluteAmount = Math.abs(amount ?? 0);
const isOriginalAmountNegative = (amount ?? 0) < 0;
Expand Down
2 changes: 2 additions & 0 deletions src/components/TransactionItemRow/TransactionItemRowWide.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,8 @@ function TransactionItemRowWide({
shouldUseNarrowLayout={false}
canEdit={canEditAmount}
onSave={onEditAmount}
report={report}
policy={policy}
/>
</View>
);
Expand Down
Loading