refactor: remove personalDetails from ReportActionsList dependencies

[LukasMod]

Explanation of Change

This PR stops the report-actions list from re-rendering when unrelated users' personal details change. Previously, the full PERSONAL_DETAILS_LIST collection was subscribed at the list level and passed down as a prop; any profile update invalidated memoization for every visible row.

The fix has two parts:

1. Report action rows — remove personalDetails prop-drilling. Each row (or small subtree) subscribes only to the account IDs it needs via useOnyx + selectors.
2. Recipient local time — move the remaining list-level PERSONAL_DETAILS_LIST usage out of ReportActionsList into a thin wrapper and shared hook so the heavy list no longer subscribes to the full collection.

Problem

ReportActionsList subscribed to the full PERSONAL_DETAILS_LIST Onyx key (via usePersonalDetails()) and passed personalDetails through ReportActionsListItemRenderer → ReportActionItem → PureReportActionItem (and related children). It also used that collection to decide composer/list padding for recipient local time.

Any update to any user's profile caused the entire report-actions list and its memoized rows to re-render.

Solution

Stop prop-drilling the full collection

personalDetails was removed from props across the report-action tree (ReportActionsListItemRenderer, ReportActionItem, ActionContentRouter, MoneyRequestReportActionsList, Search ChatListItem, debug pages, etc.).

Each component that needs a name now reads only the specific account it cares about via useOnyx with a selector:

Component	Subscription
PureReportActionItem	personalDetailsDisplayNameSelector(actorAccountID) for message accessibility labels
ReimbursementQueuedContent	personalDetailsDisplayNameSelector(ownerAccountID) for submitter copy in system messages
AncestorReportActionItem	personalDetailByAccountIDSelector(report.ownerAccountID) for thread ancestor navigation

Only rows whose actor (or owner, for reimbursement messages) actually changed will re-render.

Isolate recipient local time from ReportActionsList

The list still needed personal-details logic for bottom padding (pb4) when the recipient local-time row is not shown, but that must not live on ReportActionsList itself.

• ReportActionsListPaddingView (new) — wraps InvertedFlashList. Owns list padding, Fullstory fsClass, and composer visibility (canUserPerformWriteAction + useShouldShowComposerForActiveEditDraft). Subscribes to local-time visibility via the hook below instead of pulling the full collection into the list.
• useReportRecipientLocalTime (new) — shared hook that subscribes to PERSONAL_DETAILS_LIST with canShowReportRecipientLocalTimeSelector(report, currentUserAccountID) and returns a boolean (not the full list), so Onyx only re-renders subscribers when eligibility changes.
• canShowReportRecipientLocalTimeSelector (in @selectors/Report) — curries canShowReportRecipientLocalTime from ReportUtils for use with useOnyx.
• ComposerLocalTime — uses useReportRecipientLocalTime for eligibility; loads the recipient record with personalDetailByAccountIDSelector only when shouldShow is true (canShow && !isComposerFullSize). Avoids a second full-list subscription for display data when the row is hidden.

ReportActionsList no longer calls usePersonalDetails() or canShowReportRecipientLocalTime directly. The dead isComposerFullSize prop on the list was removed (it was never passed from ReportActionsView).

User-visible impact

None expected. Chat layout, local time, and list padding should behave the same as before.

Note: List padding does not account for expanded composer (isComposerFullSize); that matches prior behavior because the list never received that prop. Only ComposerLocalTime hides the row when the composer is full size.

Fixed Issues

$ #91609
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

1. Chat — report actions list

1. Open a chat with 20+ messages.
2. Scroll up/down through the list.
3. Send a message.
4. Pass: Messages render and scroll normally, no blank rows or console errors.

2. Accessibility — message labels (web)

1. Open a chat with messages from you and another user.
2. Open DevTools → Elements → Accessibility pane (Chrome: ⋮ → More tools → Accessibility).
3. Inspect another user's message row; note the node's Name (from aria-label / accessibilityLabel).
4. Inspect your own message row the same way.
5. Pass: Name is {sender}, {timestamp}, {message}; sender not empty for known users, no console errors.

3. Threads — ancestors & navigation

1. Open a reply thread with a visible ancestor chain.
2. Tap Thread on the divider (openable parent).
3. Tap the ancestor parent report action above replies.
4. Pass: Navigation matches pre-PR

4. Reimbursement queued

Setup (payer account A, recipient account B):

1. As A, create a USD workspace and connect a business bank account
2. Add B to the workspace. Ensure B has no personal bank account and no enabled wallet.
3. As B, submit a reimbursable expense on that workspace to A for approval.

Test:

1. As A, approve B's report and tap Pay → choose the workspace's connected bank account.
2. Open the chat as B.
3. Expected: "started payment, but is waiting for A to add a bank account" message + Add bank account button.
4. Confirm the name in the waiting copy

5. Expense report — actions list

1. Open an expense report with an activity feed.
2. Scroll the activity list.
3. Pass: Activity list renders and scrolls

6. Search — chat row preview

1. Search → results that include chat/report action rows.
2. Open a result.
3. Pass: Preview row and opened report both render; content matches preview.

7 Composer, recipient local time

1. Open a 1:1 DM (two users, different timezones if possible).
2. Open a group chat.
3. In the 1:1 DM, type until Expand appears in the composer toolbar.
4. Tap Expand, then Collapse.

Pass: 1:1 shows "It's {time} for {name}" above the composer; group has no local-time row; expand hides it, collapse brings it back; spacing above composer looks normal.

Offline tests

QA Steps

• Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Test 1:

scroll.web.1.mov

Test 2:

aria.label.web.2.mov

Test3:

threads.-.3.mov

Test4:

Test5:

expenses.5.mov

Test 6:

search.mov

Test 7:

Screen.Recording.2026-05-27.at.13.40.58.mov

[LukasMod]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx	64.63% <ø> (-0.14%)	⬇️
...onents/Search/SearchList/ListItem/ChatListItem.tsx	0.00% <ø> (ø)
src/hooks/useReportRecipientLocalTime.ts	100.00% <100.00%> (ø)
...Debug/ReportAction/DebugReportActionCreatePage.tsx	0.00% <ø> (ø)
...es/Debug/ReportAction/DebugReportActionPreview.tsx	0.00% <ø> (ø)
.../TransactionDuplicate/DuplicateTransactionItem.tsx	0.00% <ø> (ø)
src/pages/inbox/report/PureReportActionItem.tsx	91.83% <100.00%> (-0.05%)	⬇️
...x/report/ReportActionCompose/ComposerLocalTime.tsx	100.00% <100.00%> (ø)
src/pages/inbox/report/ReportActionItem.tsx	100.00% <100.00%> (ø)
src/pages/inbox/report/ReportActionsList.tsx	75.90% <ø> (-0.43%)	⬇️
... and 9 more
... and 9 files with indirect coverage changes

[LukasMod]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[melvin-bot]

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Eskalifer1]

What do you think about removing personalDetailsList from here:

App/src/pages/inbox/report/ReportActionsList.tsx

Line 186 in 9498065

const personalDetailsList = usePersonalDetails();

We only use this value in one place:

App/src/pages/inbox/report/ReportActionsList.tsx

Line 801 in 9498065

const shouldShowReportRecipientLocalTime = canShowReportRecipientLocalTime(personalDetailsList, report, currentUserAccountID) && !isComposerFullSize;

And the shouldShowReportRecipientLocalTime value is used in only one place:

App/src/pages/inbox/report/ReportActionsList.tsx

Line 892 in 9498065

style={[styles.flex1, !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pb4 : {}]}

To add the paddingBottom: 16px style.

It doesn't seem very practical to load an entire data set—which could be enormous—just to determine whether or not to indent the text

I think we can create a new component where we move the shouldShowReportRecipientLocalTime logic, thereby completely removing personalDetailsList from ReportActionsList, which will give us a performance boost. And within this component, we’ll retrieve personalDetailsList, and we’ll be able to pass hideComposer and reportActionsListFSClass to it as props

[Eskalifer1]

Please add indentation before video links so that GitHub can automatically detect them and display the videos instead of just the links

[Eskalifer1]

Also, if you have any steps or, for example, a value that can be set in Onyx to trigger a Report action for the fourth text, I think it’s worth adding that to the tests, since QA will definitely ask how to trigger that message

[Eskalifer1]

And let's merge main!

I will complete checklist tomorrow

[Eskalifer1]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

91609-android-native.mov

Android: mWeb Chrome

91609-android-web.mov

iOS: HybridApp

91609-ios-native-1.mov

91609-ios-native-2.mov

iOS: mWeb Safari

91609-ios-web.mov

MacOS: Chrome / Safari

91609-web.mov

[Eskalifer1]

Hi @LukasMod Seems like we have some eslint and ts problems after merging main

[Eskalifer1]

@codex review

[LukasMod]

Looking into that now

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[LukasMod]

@Eskalifer1 all green now 🎉

[Eskalifer1]

LGTM!

[LukasMod]

New conflicts resolved

[cristipaval]

Looks great! Thanks @LukasMod! 🙏

This is on you now, @mountiny

[mountiny]

thank you!

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91416.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-78660070302-04e63f5-1b165335c5a66a33659b3a762bac0b1a05fc51ff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7866007-04e63f5-ce71bc76a1e4f75bf5e2238a21b15bab017ff032/index.html

Web 🕸️
https://91416.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.90-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

🤖 No help site changes required.

I reviewed the changes in this PR against the help site articles under App/docs/articles, and no documentation updates are needed.

Why: This is a pure performance/architecture refactor — it stops ReportActionsList from re-rendering when unrelated users' personal details change (removes PERSONAL_DETAILS_LIST prop-drilling, isolates recipient local-time logic into a wrapper + hook). It does not add, remove, or change any user-facing feature, flow, label, or copy.

Evidence

• The PR description states: "User-visible impact: None expected. Chat layout, local time, and list padding should behave the same as before."
• All 25 changed files are internal src/ source files (components, hooks, pages, selectors) and tests/ files.
• No src/languages/* files changed → no user-facing copy/text was added or modified.
• No App/docs/articles/** files are affected by this behavior.

Help site articles document user-facing product behavior, features, and copy. Since none of those changed here, there is nothing to update.

Since no documentation changes are required, I did not create a draft help site PR. If you believe a specific behavior described in the docs has actually changed, reply with @MelvinBot <details> and I'll take another look.

[jponikarchuk]

This PR failing because of the issue #92225
This issue is reproducible in: Android app, Web

Bug7168482_1780314053297.Chat_Tests.mp4

[mountiny]

@jponikarchuk Is that only in staging and stemming from this PR?

[VickyStash]

@mountiny Issue says it's repro in prod as well.

[Eskalifer1]

I don't think this applies to our PR, since the bug occurs on both stage and prod, which means it's not due to our changes.

Perhaps QA didn't quite understand the last test correctly; specifically, they expect this text to always be there (which isn't the case), which is why the issue was created.

I just logged in and checked myself, and indeed, this text isn’t displayed in all chats, which is to be expected, and the same behavior is observed on prod. In those chats where this text is present on prod, it’s also displayed on stage...

What do you think about this @LukasMod @mountiny?

[mountiny]

Cool, I missed that, thanks

[VickyStash]

Yeah, the label is shown for me on staging too

[OSBotify]

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅