Skip useTransactionInlineEdit on narrow transaction rows to reduce scroll jank

[TMisiukiewicz]

Explanation of Change

useTransactionInlineEdit subscribes to 12+ Onyx keys per row. On iOS narrow-layout transaction rows (TransactionItemRowNarrow), none of those subscriptions are consumed — the narrow layout has no inline-edit cells — so every row was paying a pure subscription overhead cost, which manifested as blank cells during fast-scroll on large reports.

Two surfaces are fixed:

1. MoneyRequestReportTransactionItem — split into a router component, a WithInlineEdit wrapper (wide path only, calls the hook), and a shared Body component that renders the Pressable scaffold. Narrow path skips the hook entirely; a local useRef(false) replaces wasEditingOnMouseDownRef so the press-handler shape stays identical.

2. Search/SearchList/ListItem/TransactionListItem — the parent (index.tsx) no longer calls useTransactionInlineEdit. TransactionListItemWide now calls the hook internally and owns its own press/mousedown/hoverIn handlers + shouldDisableHoverStyle state. TransactionListItemNarrow gets a simplified press handler with no editing-dismissal logic (unnecessary since narrow has no inline-edit cells). The TransactionListItemInlineEditProps type is removed; currentSearchHash is passed as a prop to wide so it can forward it to the hook.

Fixed Issues

$ #91823
PROPOSAL:

Tests

Web

1. Go to Spends -> Reports
2. Open Report with multiple expenses that are not yet approved
3. Verify you are able to do an inline edit of the transactions

Rest of the platforms

1. Go to Spends -> Reports
2. Open the same report as on web
3. Verify you are not able to do an inline edit of the transactions

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Untitled.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-27.at.12.11.18.mov

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../SearchList/ListItem/TransactionListItem/index.tsx	0.00% <ø> (ø)
.../TransactionListItem/TransactionListItemNarrow.tsx	0.00% <0.00%> (ø)
...stReportView/MoneyRequestReportTransactionItem.tsx	0.00% <0.00%> (ø)
...em/TransactionListItem/TransactionListItemWide.tsx	0.00% <0.00%> (ø)
... and 15 files with indirect coverage changes

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@jayeshmangwani @rlinoz One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

Assigning to @aimane-chnaif as this is a follow up to another PR they are reviewing

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[aimane-chnaif]

This switching causes unmount/remount on web browser resizing.
So it causes issues like losing the highlight animation state from useAnimatedHighlightStyle.
Rare in practice but worth flagging — the original kept a single component instance across layouts.

[TMisiukiewicz]

fixed

[aimane-chnaif]

@codex review

[MelvinBot]

Code Review

Overall this is a well-structured performance optimization. Moving useTransactionInlineEdit out of the narrow path eliminates 12+ unnecessary Onyx subscriptions per row during fast-scroll — solid win. A few observations:

1. Unmount/remount on resize (flagged by aimane-chnaif)

The router in MoneyRequestReportTransactionItem (line 249–253) conditionally renders either MoneyRequestReportTransactionItemBody or MoneyRequestReportTransactionItemWithInlineEdit. When isNarrowLayout toggles (e.g. browser resize), React unmounts one tree and mounts the other, which resets useAnimatedHighlightStyle state. This is a real concern — the original single-component approach preserved component identity across layout changes.

Suggestion: Consider wrapping the hook call in an early-return guard inside the body rather than splitting into two component trees. Something like conditionally skipping the hook's effects (if the hook supports a disabled/skip option) would avoid the unmount. Alternatively, if the unmount is acceptable given it only occurs on resize (rare on mobile, infrequent on web), document that trade-off explicitly.

2. Redundant responsive-layout hooks

The router (line 244–245) calls useResponsiveLayout() and useResponsiveLayoutOnWideRHP(), and then the Body component (line 111–112) calls them again. This is harmless (they're lightweight context reads), but you could pass isNarrowLayout as a prop to avoid the double subscription.

3. fallbackEditingOnMouseDownRef is safe but adds cognitive overhead

The fallback ref (line 121–122) keeps the press handler shape identical, which is clean. However, the Body component still calls useEditingCellState() (line 108) on narrow — that subscription is no longer useful on narrow since there are no editable cells. Consider guarding it behind inlineEdit to fully eliminate narrow-path overhead.

4. TransactionListItemWide — looks correct

The hook, state, and handlers moved from index.tsx into TransactionListItemWide.tsx are functionally equivalent. The useEffect + queueMicrotask pattern for shouldDisableHoverStyle is preserved identically. No hook-rules violations since the wide component is only rendered when isLargeScreenWidth is true.

5. Type cleanup is clean

Removing TransactionListItemInlineEditProps and introducing TransactionListItemSharedProps simplifies the type surface nicely. The new currentSearchHash prop on TransactionListItemWideProps is the only addition — minimal and clear.

---

Summary: The core optimization is correct and the data flow is sound. The main point to resolve is the unmount/remount concern from the existing review comment — either accept the trade-off with documentation, or restructure to avoid the conditional component switch.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[aimane-chnaif]

Please check above comments

[TMisiukiewicz]

updated the PR

[aimane-chnaif]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

[MelvinBot]

No regressions found. Here's a summary of what was verified:

Layout check consistency — The isNarrowLayout gate in the outer MoneyRequestReportTransactionItem (shouldUseNarrowLayout || (isMediumScreenWidth && !shouldScrollHorizontally)) matches the shouldUseNarrowLayout prop passed to TransactionItemRow. TransactionItemRow does not compute layout independently — it branches on the prop — so the hook-skip decision and the render decision are guaranteed to agree.

Undefined edit props on narrow — All edit props (canEditDate, onEditDate, etc.) are optional in TransactionItemRowProps and EditableProps. EditableCell renders a plain <View> when canEdit is falsy. TransactionItemRowNarrow uses a Pick type that excludes all edit props entirely — it never references them.

Hook arguments after the move — currentSearchHash is correctly threaded from index.tsx → TransactionListItemWide as a prop. The useTransactionInlineEdit call in Wide passes all three args (transactionID, hash, linkedReportAction) identically to how the old parent did.

MoneyRequestReportTransactionItem omitting hash/linkedReportAction — Both are optional in useTransactionInlineEdit. When hash is undefined the hook skips search snapshot updates (not needed outside Search). When linkedReportAction is undefined it falls back to getIOUActionForTransactionID. This is the designed fallback path.

useEditingCellState moved to Wide only — It's a pure context consumer (useContext(EditingCellStateContext)) with no special requirements. It was never used by the narrow variant, so confining it to Wide is correct.

Event handler type change — PressableWithFeedback.onPress provides GestureResponderEvent | KeyboardEvent, which satisfies the ModifiedMouseEvent structural type that onSelectRow expects. Compatible at runtime.

[mountiny]

Thank you

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91810.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-86565b9ab18-4205783-e3da9a99b9a526bb1b45607ea67788b5dffb07ee/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-86565b9-4205783-f18fc8f5219db102fdc71b0636a56440bd86196a/index.html

Web 🕸️
https://91810.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀