Add highcontrast btn in signin page and sync it with server values by rushatgabhane · Pull Request #92117 · Expensify/App

rushatgabhane · 2026-05-29T21:31:26Z

Explanation of Change

Fixed Issues

$ #92049
PROPOSAL:

Tests

Tests: high contrast on sign-in

On Sign in page, verify that "Enable high contrast" button shows above language selector.
Tap the button
Verify thatpage goes high-contrast.
Tap again. Verify page is normal contrast.
Sign in and verify that the theme updates to contrast version of whatever the past theme was.

Post login

Set the server theme as System and enable high contrast
Sign out. Verify that theme stays system-contrast

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-29.at.23.23.48.mov

melvin-bot · 2026-05-29T21:31:30Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

melvin-bot · 2026-05-29T21:42:21Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-29T21:42:26Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…to home-high-contrast

rushatgabhane · 2026-05-29T21:50:06Z

I need to increase width of language selector i guess

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f87a7e0d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-05-29T21:56:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.79% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
...rc/components/Icon/chunks/expensify-icons.chunk.ts	`0.00% <ø> (ø)`
...Navigation/AppNavigator/AuthScreensInitHandler.tsx	`96.66% <100.00%> (+0.05%)`	⬆️
src/libs/actions/App.ts	`51.44% <ø> (ø)`
src/pages/signin/Licenses.tsx	`100.00% <100.00%> (ø)`
src/pages/signin/SignInPage.tsx	`75.18% <100.00%> (+0.36%)`	⬆️
src/components/HighContrastModeSwitcher.tsx	`87.50% <87.50%> (ø)`
src/hooks/useReconcileHighContrastIntent.ts	`71.42% <71.42%> (ø)`
src/libs/actions/User.ts	`36.26% <37.50%> (+0.02%)`	⬆️
... and 11 files with indirect coverage changes

rushatgabhane · 2026-05-29T22:10:46Z

Updated the width

rushatgabhane · 2026-05-29T22:11:37Z

I still need svg for this icon

Eskalifer1 · 2026-06-03T10:15:43Z

Actually i can reproduce probably the same bug on staging, so it's now related to our changes

2026-06-03.13.13.44.mov

Eskalifer1 · 2026-06-03T10:15:58Z

Let's merge main to fix eslint+ts

Eskalifer1 · 2026-06-03T12:54:18Z

What should we do about this bug? Should we just ignore it here, or is this actually the expected behavior and supposed to be that way?

If we don't fix this here, within the scope of this PR, then I haven't found any other issues

rushatgabhane · 2026-06-03T18:54:51Z

Hi @rushatgabhane, i can still reproduce #92117 (review)...

we do theme reconciliation when the user signs in - and not when they click sign in button (this is session only)

maybe there is an easy fix. but i don't think we should block on it

rushatgabhane · 2026-06-03T18:56:36Z

@Eskalifer1 all yours! thank you for the extensive review

Eskalifer1 · 2026-06-03T20:04:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 490dc31164

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1 · 2026-06-05T13:35:36Z

@codex review

chatgpt-codex-connector · 2026-06-05T13:40:55Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1

LGTM!

I'm going to be OOO all next week. So wi will not be able to do smth with regressions if they appear...

melvin-bot · 2026-06-05T13:58:48Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #92049 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

luacmartins

LGTM

github-actions · 2026-06-05T15:30:54Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-05T15:34:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-05T15:37:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92117.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0c5539a7736-a8a87d5-bf082f1ce36a80b7067988c428ec3674c956d410/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0c5539a-a8a87d5-7b5e5eeb041a8834a8d4d2b1bf9e1e826ec1cc36/index.html

Web 🕸️
https://92117.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-05T18:16:16Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-05T18:31:57Z

🤖 Reviewed this PR for help site impact under App/docs/articles.

Help site changes are required. This PR adds an Enable high contrast button to the logged-out sign-in screen (above the language selector), letting users turn on high contrast mode before signing in. The existing Account Settings article only documented enabling high contrast from Account > Preferences > Theme while signed in, so the new sign-in screen flow was undocumented.

I created a draft help site PR: #92805

Added a task-based section How to enable high contrast mode from the sign-in screen to docs/articles/new-expensify/settings/Account-Settings.md.
Used the exact UI labels verified against source (src/languages/en.ts, HighContrastModeSwitcher.tsx, Licenses.tsx): Enable high contrast / Disable high contrast, positioned above the language selector.

@rushatgabhane, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

mitarachim · 2026-06-05T20:49:36Z

Deploy Blocker #92824 was identified to be related to this PR.

OSBotify · 2026-06-09T04:10:30Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

QichenZhu · 2026-06-19T04:19:24Z

+    const icons = useMemoizedLazyExpensifyIcons(['Moon']);
+
+    const currentTheme = preferredTheme ?? CONST.THEME.DEFAULT;
+    const isHighContrast = isHighContrastTheme(currentTheme);


The button state should be consistent with the UI, which takes the user's intended theme into account:

App/src/pages/signin/SignInPage.tsx

Line 365 in 48de65f

const isHighContrast = highContrastIntent ?? contrastThemes.includes(preferredTheme ?? '');

Fixed via #92978.

add highcontrast btn in signin page and sync it with server values

11040f9

melvin-bot Bot assigned rushatgabhane May 29, 2026

rushatgabhane commented May 29, 2026

View reviewed changes

Comment thread src/libs/actions/User.ts Outdated

rushatgabhane commented May 29, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

rushatgabhane commented May 29, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

rushatgabhane commented May 29, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

Apply suggestions from code review

7f87a7e

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

rushatgabhane marked this pull request as ready for review May 29, 2026 21:42

rushatgabhane requested review from a team as code owners May 29, 2026 21:42

melvin-bot Bot requested review from Eskalifer1 and JmillsExpensify and removed request for a team May 29, 2026 21:42

melvin-bot Bot requested review from a team and Krishna2323 and removed request for a team May 29, 2026 21:42

github-actions Bot reviewed May 29, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

rushatgabhane added 2 commits May 29, 2026 23:48

add a11y label to icon

60f88c0

Merge branch 'home-high-contrast' of github.com:rushatgabhane/exfy in…

2069610

…to home-high-contrast

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

add maxwidth 150px

e8db467

rushatgabhane requested a review from a team as a code owner May 29, 2026 22:10

Merge branch 'Expensify:main' into home-high-contrast

490dc31

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread src/libs/actions/User.ts Outdated

rushatgabhane added 3 commits June 5, 2026 00:05

Merge branch 'Expensify:main' into home-high-contrast

b93685c

anonymous account - local only

239c21f

fix signin

48de65f

Eskalifer1 approved these changes Jun 5, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins June 5, 2026 13:59

luacmartins approved these changes Jun 5, 2026

View reviewed changes

luacmartins merged commit 0c5539a into Expensify:main Jun 5, 2026
35 checks passed

OSBotify mentioned this pull request Jun 5, 2026

Deploy Checklist: New Expensify 2026-06-05 #92792

Closed

MelvinBot mentioned this pull request Jun 5, 2026

[No QA] Docs updates for E/A#92117 high contrast on sign-in screen #92805

Merged

applause-bot Bot mentioned this pull request Jun 5, 2026

[Due for payment 2026-06-19] [$250] Android - Login - Enable high contrast button is shown when high contrast mode is enabled #92824

Closed

7 tasks

mitarachim mentioned this pull request Jun 5, 2026

[Due for payment 2026-06-16] Add high contrast option to sign up screen #92049

Closed

QichenZhu reviewed Jun 19, 2026

View reviewed changes

Conversation

rushatgabhane commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Tests: high contrast on sign-in

Post login

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

Uh oh!

rushatgabhane commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented May 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rushatgabhane commented May 29, 2026

Uh oh!

rushatgabhane commented May 29, 2026

Uh oh!

Eskalifer1 commented Jun 3, 2026

Uh oh!

Eskalifer1 commented Jun 3, 2026

Uh oh!

Eskalifer1 commented Jun 3, 2026

Uh oh!

rushatgabhane commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Jun 3, 2026

Uh oh!

Eskalifer1 commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Eskalifer1 commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

Eskalifer1 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 5, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

MelvinBot commented Jun 5, 2026

rushatgabhane commented May 29, 2026 •

edited

Loading

rushatgabhane commented May 29, 2026 •

edited

Loading

codecov Bot commented May 29, 2026 •

edited by github-actions Bot

Loading

rushatgabhane commented Jun 3, 2026 •

edited

Loading