Skip to content

[No QA] Clarify that "Manually" submission frequency still auto-adds expenses to a report#92121

Merged
stephanieelliott merged 8 commits into
mainfrom
claude-clarifyManuallyAutoSubmissionDoc
Jun 16, 2026
Merged

[No QA] Clarify that "Manually" submission frequency still auto-adds expenses to a report#92121
stephanieelliott merged 8 commits into
mainfrom
claude-clarifyManuallyAutoSubmissionDoc

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Clarifies the Manually option of the workspace Submissions frequency in two help articles so it is clear that expenses are still auto‑added to a report — the "Manually" frequency only controls when reports are submitted, not whether expenses are placed on a report.

This was prompted by AgentZero recommending that an admin switch from the Weekly auto‑submission cadence to the Manually option so "expenses stay Unreported." Per the existing docs, the Manually option still auto‑adds expenses to reports, so the recommendation did not match the user's intent. AgentZero's logged reasoning shows it conflated the Workspace Workflows FAQ phrase "if no submission frequency is chosen, expenses remain Unreported" with the Manually option in How‑to‑Set‑Up‑Automatic‑Report‑Submissions. Making the Manually bullet more explicit in both articles should reduce that misinterpretation for both customers and the LLM.

Files updated:

  • docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/635321
PROPOSAL: https://github.com/Expensify/Expensify/issues/635321#issuecomment-4580434464

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — help-site markdown content change.

…o a report

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team May 29, 2026 23:10
@github-actions github-actions Bot changed the title Clarify that "Manually" submission frequency still auto-adds expenses to a report [No QA] Clarify that "Manually" submission frequency still auto-adds expenses to a report May 29, 2026
@OSBotify

This comment has been minimized.

Per feedback on the linked issue, document that toggling Submissions
off (not the Manually frequency) is what prevents expenses from being
auto-added to a report. Also fix the contradictory "off = submitted
instantly" line in Workspace-Workflows so it matches the FAQ behavior.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Added the Submissions toggle OFF → Unreported clarification. Two changes pushed in ae24d85:

  • docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md — added an inline callout under the frequency list explicitly stating that toggling Submissions off is what keeps expenses Unreported (and that "Manually" does not), plus a new FAQ entry "How do I stop expenses from being automatically assigned to reports?" so the answer is discoverable for both customers and AgentZero retrieval.
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md — the existing bullet here read "If turned off, all reimbursable and non-reimbursable expenses are submitted instantly," which contradicted both the FAQ on the same page and the corrected behavior. Updated it to: "If Submissions is turned off, expenses stay in the Unreported state until a member adds them to a report… This is the only configuration that prevents expenses from being auto-added to a report." Flagging this change explicitly in case you'd like the previous wording preserved — happy to revert that one line if it was intentional.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott removed the request for review from a team May 30, 2026 04:01
@stephanieelliott stephanieelliott marked this pull request as ready for review May 30, 2026 04:01
@stephanieelliott stephanieelliott self-requested a review as a code owner May 30, 2026 04:01
@OSBotify

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR clarifies the behavior of the Manually submission frequency across two help articles, making it explicit that expenses are still auto-added to reports even when Manually is selected. The changes are well-motivated (correcting an LLM misinterpretation) and improve precision. A few issues in the new text need attention before merge.

Scores Summary

  • Readability: 7/10 - The clarifications are clear and actionable, but one grammatical error ("turned disabled") and a trailing whitespace reduce polish. The added paragraph in the first file is slightly dense but still scannable.
  • AI Readiness: 8/10 - The changes explicitly disambiguate "Manually" from "Submissions off," which directly addresses the LLM conflation issue described in the PR. Bold emphasis on key terms like auto-added to a report and Unreported improves semantic retrieval. No new headings were needed or added, which is appropriate.
  • Style Compliance: 7/10 - UI element bolding is correctly applied. However, there is a grammar issue in the Workspace-Workflows.md note, and one sentence has a trailing space before the line break.

Key Findings

  • Grammar error (must fix): In Workspace-Workflows.md, the added note reads "If Submissions is turned disabled" -- this should be either "If Submissions is disabled" or "If Submissions is turned off" to match standard phrasing and read correctly.
  • Trailing whitespace: In How-to-Set-Up-Automatic-Report-Submissions.md, the modified Manually bullet ends with a trailing space after the period. Minor, but worth cleaning up.
  • Positive: Disambiguation is well done. The added text in both files clearly distinguishes between the Manually frequency (auto-adds expenses, delays submission) and toggling Submissions off (expenses stay Unreported). This directly serves both human readers and AI retrieval.
  • Positive: Consistent messaging. Both articles now convey the same clarification, reducing the risk of conflicting information across docs.
  • Removed bullet concern: In Workspace-Workflows.md, the old bullet "If turned off, all reimbursable and non-reimbursable expenses are submitted instantly" was removed and replaced with a note that says the opposite behavior (expenses stay Unreported). If the old bullet was factually incorrect, the removal is appropriate. If it described a different scenario, confirm the old content was indeed wrong before merging.

Recommendations

  1. Fix the grammar error in Workspace-Workflows.md: Change "If Submissions is turned disabled" to "If Submissions is disabled" or "If Submissions is turned off."
  2. Remove trailing whitespace on the Manually bullet in How-to-Set-Up-Automatic-Report-Submissions.md.
  3. Verify factual accuracy of removing the old "submitted instantly" bullet from Workspace-Workflows.md -- confirm the replacement note accurately describes the current product behavior.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.md - Manually bullet clarified; new paragraph added explaining Submissions-off behavior. Minor trailing whitespace issue.
  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md - Manually bullet clarified; old bullet replaced with note. Contains a grammar error that must be fixed.

Review based on governance rules defined in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. Only proposed changes (diff) were evaluated.

Comment thread docs/articles/new-expensify/workspaces/Workspace-Workflows.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Workspace-Workflows.md Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott requested a review from a team June 6, 2026 02:00
@melvin-bot

melvin-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @johncschuster

@melvin-bot melvin-bot Bot requested review from johncschuster and removed request for a team June 6, 2026 02:00
@melvin-bot

melvin-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 6, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Bump @johncschuster, can you please review?

@stephanieelliott

Copy link
Copy Markdown
Contributor

bump @johncschuster!

@johncschuster

Copy link
Copy Markdown
Contributor

On it!

@johncschuster johncschuster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!

@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott merged commit 1cbb5bf into main Jun 16, 2026
17 checks passed
@stephanieelliott stephanieelliott deleted the claude-clarifyManuallyAutoSubmissionDoc branch June 16, 2026 23:34
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.14-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants