[No QA] Clarify that "Manually" submission frequency still auto-adds expenses to a report#92121
Conversation
…o a report Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Per feedback on the linked issue, document that toggling Submissions off (not the Manually frequency) is what prevents expenses from being auto-added to a report. Also fix the contradictory "off = submitted instantly" line in Workspace-Workflows so it matches the FAQ behavior. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Added the Submissions toggle OFF → Unreported clarification. Two changes pushed in
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR clarifies the behavior of the Manually submission frequency across two help articles, making it explicit that expenses are still auto-added to reports even when Manually is selected. The changes are well-motivated (correcting an LLM misinterpretation) and improve precision. A few issues in the new text need attention before merge. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on governance rules defined in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. Only proposed changes (diff) were evaluated. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
|
Bump @johncschuster, can you please review? |
|
bump @johncschuster! |
|
On it! |
|
A preview of your ExpensifyHelp changes have been deployed to https://ada7f20a.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
Explanation of Change
Clarifies the Manually option of the workspace Submissions frequency in two help articles so it is clear that expenses are still auto‑added to a report — the "Manually" frequency only controls when reports are submitted, not whether expenses are placed on a report.
This was prompted by AgentZero recommending that an admin switch from the Weekly auto‑submission cadence to the Manually option so "expenses stay Unreported." Per the existing docs, the Manually option still auto‑adds expenses to reports, so the recommendation did not match the user's intent. AgentZero's logged reasoning shows it conflated the Workspace Workflows FAQ phrase "if no submission frequency is chosen, expenses remain Unreported" with the Manually option in How‑to‑Set‑Up‑Automatic‑Report‑Submissions. Making the Manually bullet more explicit in both articles should reduce that misinterpretation for both customers and the LLM.
Files updated:
docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.mddocs/articles/new-expensify/workspaces/Workspace-Workflows.mdFixed Issues
$ https://github.com/Expensify/Expensify/issues/635321
PROPOSAL: https://github.com/Expensify/Expensify/issues/635321#issuecomment-4580434464
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — help-site markdown content change.