Skip to content

[No QA] Docs updates for E/A#92117 high contrast on sign-in screen#92805

Merged
zanyrenney merged 2 commits into
mainfrom
docs-high-contrast-signin
Jun 10, 2026
Merged

[No QA] Docs updates for E/A#92117 high contrast on sign-in screen#92805
zanyrenney merged 2 commits into
mainfrom
docs-high-contrast-signin

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

PR #92117 added an Enable high contrast button to the logged-out sign-in screen, letting users turn on high contrast mode before signing in (for accessibility). The existing help article only documented enabling high contrast from Account > Preferences > Theme while signed in.

This updates the Account Settings help article to document the new sign-in screen flow.

Changes

  • Added a new task-based section How to enable high contrast mode from the sign-in screen to docs/articles/new-expensify/settings/Account-Settings.md.
  • Used the exact UI labels verified against source: Enable high contrast / Disable high contrast, positioned above the language selector.

Related


@rushatgabhane, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Add a help-site section covering the new high contrast toggle available on
the logged-out sign-in screen (E/A#92117).

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 5, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing build check (Deploy ExpensifyHelp) is unrelated to this PR's changes — it's a repo-wide CI infrastructure issue affecting every open docs PR, so there's nothing in this PR to fix.

Root cause: The Install pcregrep step runs sudo apt-get install -y pcregrep and fails with:

E: Unable to locate package pcregrep

apt can't locate the pcregrep package on the blacksmith-2vcpu-ubuntu-2404 runner, so the job aborts before it ever touches the docs.

Evidence it's not this PR:

  • This PR only changes one file: docs/articles/new-expensify/settings/Account-Settings.md.
  • The identical step is failing on at least 7 different docs PR branches since ~18:19 UTC today (e.g. claude-docsYourSpendThirdPartyCards, docs-intacct-travel-invoicing-cr, docs-xero-travel-invoicing-cr), while earlier main deploy runs on the same runner succeeded (last green ~15:05 UTC). Something changed in the runner's apt environment between those times.

Recommended fix (separate infra PR — not this docs PR): Add an apt-get update before the install so apt has a fresh package index:

- name: Install pcregrep
  run: |
    sudo apt-get update
    sudo apt-get install -y pcregrep

The package was installable on the same runner earlier today, so a stale package index is the most likely cause. If pcregrep has actually been dropped from the Ubuntu 24.04 repos, the more durable fix is to switch to pcre2grep (package pcre2-utils) and update the three pcregrep calls in enforceVideoFormats.sh.

I'm intentionally not bundling this workflow change into this docs PR, since it's a production deploy-workflow fix with repo-wide impact and belongs in its own PR. Once that lands (or the runner environment recovers), re-running this check should pass with no changes needed here.

@rushatgabhane

Copy link
Copy Markdown
Member

@MelvinBot make ready for review

1 similar comment
@rushatgabhane

Copy link
Copy Markdown
Member

@MelvinBot make ready for review

@MelvinBot MelvinBot marked this pull request as ready for review June 9, 2026 16:11
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single new section to the Account Settings help article, documenting how to enable high contrast mode from the sign-in screen. The change is small (15 lines), well-scoped, and closely follows the governance standards. It documents a single workflow addition cleanly and positions it logically after the existing high contrast content.

Scores Summary

  • Readability: 9/10 - Clear, concise steps with good explanatory text. The two-step procedure is easy to follow, and the outcome paragraph ("The screen immediately switches...") sets expectations well.
  • AI Readiness: 9/10 - The heading "How to enable high contrast mode from the sign-in screen" is task-based, includes the feature name, uses a "How to" pattern, and is highly searchable. The screenshot placeholder follows the required HTML comment format exactly. The only minor gap is that the existing file's YAML frontmatter does not include internalScope, but that is pre-existing and outside the scope of this diff.
  • Style Compliance: 10/10 - UI labels Enable high contrast and Disable high contrast are bolded and appear to match the exact product UI text. The section uses ## heading level correctly. No prohibited language is used. Navigation language is clear and specific.

Key Findings

  • The new ## How to enable high contrast mode from the sign-in screen heading is properly task-based and starts with an action phrase, satisfying HELP_AUTHORING_GUIDELINES.md Section 2.
  • Button names (Enable high contrast, Disable high contrast) are correctly bolded per HELPSITE_NAMING_CONVENTIONS.md button formatting rules.
  • The screenshot placeholder uses the exact required format (<!-- SCREENSHOT: with Suggestion, Location, and Purpose fields).
  • The section maintains single-workflow focus -- it only covers the sign-in screen flow, complementing (not duplicating) the existing signed-in flow section above it.
  • Step 1 uses "go to the footer above the language selector" which is specific and avoids prohibited vague navigation language.

Recommendations

  • No blocking issues. This is a clean, well-structured addition.
  • Minor suggestion: In step 1, "go to the footer above the language selector" could be slightly more direct, e.g., "Look for the Enable high contrast button in the footer, above the language selector." This would front-load the UI element the user is looking for. However, the current phrasing is acceptable.

Files Reviewed

  • docs/articles/new-expensify/settings/Account-Settings.md - 15 lines added. New section documenting high contrast mode on the sign-in screen. Passes all governance checks for the proposed changes.

Comment thread docs/articles/new-expensify/settings/Account-Settings.md Outdated
Comment thread docs/articles/new-expensify/settings/Account-Settings.md Outdated
@stephanieelliott stephanieelliott requested a review from a team June 9, 2026 20:21
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot melvin-bot Bot requested review from zanyrenney and removed request for a team June 9, 2026 20:22
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions Bot changed the title Docs updates for E/A#92117 high contrast on sign-in screen [No QA] Docs updates for E/A#92117 high contrast on sign-in screen Jun 9, 2026
@OSBotify

OSBotify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://d0761dc3.helpdot.pages.dev ⚡️

Updated articles:

@zanyrenney zanyrenney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough!

@zanyrenney zanyrenney merged commit eb28d19 into main Jun 10, 2026
15 checks passed
@zanyrenney zanyrenney deleted the docs-high-contrast-signin branch June 10, 2026 16:34
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.4.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants