[$250] Fix flaky test: PaginationTest timeout 120s → 240s#93651
Closed
crystal-tensor wants to merge 1 commit into
Closed
[$250] Fix flaky test: PaginationTest timeout 120s → 240s#93651crystal-tensor wants to merge 1 commit into
crystal-tensor wants to merge 1 commit into
Conversation
The 'opens a chat and load initial messages' test intermittently times out at 120s on loaded CI runners even though it runs in ~42s locally. Previous fix (Expensify#74232) reduced flakiness but did not eliminate the 120s timeout edge case on slower runners. Bump to 240s to match tests/perf-test/setupAfterEnv.ts precedent and eliminate the timeout flake entirely.
Contributor
|
👋 Hi @crystal-tensor, thanks for your interest in contributing to Expensify! This PR has been automatically closed because it doesn't appear to meet our contribution requirements:
If you'd like to contribute, please make sure to:
Please review our contributing guidelines for more details. If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
$ #92493 — `tests/ui/PaginationTest.tsx` › `opens a chat and load initial messages` intermittently times out at 120s on loaded CI runners.
The test consistently runs in ~42s locally but occasionally exceeds the 120s global `jest.setTimeout` on slower CI runners (#84791). A previous fix (#74232) reduced flakiness but did not eliminate the timeout edge case.
Fix
Increase `jest.setTimeout` in PaginationTest.tsx from `120000` to `240000` (4 minutes), matching the precedent set by `tests/perf-test/setupAfterEnv.ts` (also 240000ms). This is a safe, non-behaviour-changing increase that eliminates the timeout flake without altering test logic or assertions.
Testing
CI run of `tests/ui/PaginationTest.tsx` should complete without timeout errors.
/assign @neil-marcellini
/assign @mallenexpensify
/price $250