[No-QA] refactor: introduce shared Overlay primitives by TaduJR · Pull Request #94127 · Expensify/App

TaduJR · 2026-06-21T13:13:10Z

Explanation of Change

M1 of a five-PR split of the Modal v2 / Dialog / Popover v2 / PopoverMenu v2 decomposition. This PR ships the shared bottom layer — a new Overlay/ primitive folder plus a few small cross-feature hooks/libs — that the next four PRs compose on. No consumer migration here; every existing user-facing surface is byte-identical to main.

Contents:

src/components/Overlay/: DismissableLayer, FloatingHost, Portal, Presence, AnimatedSurface, createHeadingSystem, plus 12 hooks (Esc handling, anchored positioning, aria-hide, body-scroll lock, focus management, etc.) and 7 libs (anchor measurement, dismissable-layer stack store, external-store factory, etc.)
Cross-feature hooks: useCallbackRef, useControlledState, useDisclosureState
Cross-feature libs: composeEventHandlers, isHTMLElement
Non-breaking widening: FocusTrapForModal.shouldReturnFocus accepts () => boolean so M2 can resolve the Composer-focus baton at restore time
Re-exports PressableRefElement from Pressable/GenericPressable/types.ts so M1's measureAnchor / overlayStore can type their anchor refs
2 CONST entries (OVERLAY_FADE_IN_WEB / OVERLAY_FADE_OUT_WEB), 1 style (overlayPortalHost)

Fixed Issues

$ #91238
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-06-21T13:13:16Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-21T13:19:27Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Overlay/FloatingHost.tsx	`100.00% <100.00%> (ø)`
src/components/Overlay/Portal/index.tsx	`100.00% <100.00%> (ø)`
src/components/Overlay/PortalContext.ts	`100.00% <100.00%> (ø)`
...nts/Overlay/hooks/useAnchoredPosition/index.web.ts	`100.00% <100.00%> (ø)`
...ents/Overlay/hooks/useDismissOnAnchorMove/index.ts	`100.00% <100.00%> (ø)`
src/components/Overlay/hooks/useHeadingState.ts	`100.00% <100.00%> (ø)`
src/components/Overlay/hooks/useOverlayEntry.ts	`100.00% <100.00%> (ø)`
src/components/Overlay/hooks/useOverlayTrigger.ts	`100.00% <100.00%> (ø)`
src/components/Overlay/libs/asHostElement.ts	`100.00% <100.00%> (ø)`
src/components/Overlay/libs/portalMarkers.ts	`100.00% <100.00%> (ø)`
... and 29 more
... and 33 files with indirect coverage changes

linhvovan29546 · 2026-06-22T09:32:49Z

@TaduJR This PR introduce ~4000 lines of new code have no production consumer — nothing in Modal, Popover, or PopoverMenu imports from it. The unit tests verify internal logic, but real integration (focus, navigation, Onyx state) is untested until M2-M5. Could we include at least one thin integration proof (e.g., migrating a single popover to FloatingHost) to validate the foundation end-to-end before building on top of it? cc @roryabraham, what are your thoughts?

roryabraham · 2026-06-25T18:53:28Z

I agree that integrating at least one usage so we have something to test would be ideal

TaduJR · 2026-06-27T10:54:54Z

yes please - some code snippets that show examples for how these components are intended to be used

@roryabraham

Took sometime and written README. I think it deserves README.md like we did on PopoverMenu.

TaduJR · 2026-06-29T20:47:05Z

Hi Everyone,

How are we doing here? I see that blocker PR is merged.

linhvovan29546 · 2026-06-30T01:50:10Z

I'll continue the review today.

linhvovan29546 · 2026-06-30T07:37:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

linhvovan29546 · 2026-07-01T08:45:28Z

This is a new pattern for storing data, similar to a tiny Zustand-style store. @roryabraham, what do you think about this pattern?

without digging in, my sense is that we almost certainly don't need it. It seems relatively reasonable, but we shouldn't introduce new patterns lightly because they have a tendency to spread virally throughout the code. This is definitely one I'd want to discuss in #expert-contributors with a clear understanding for why we're proposing adding it.

Removed and made it inline.

But we should really handle this in appropriate and DRY way because I am seeing similar pattern on over ~10 places.

I think discussion with #expert-contributor is a great idea!

Can you list out some of the places where you see a similar pattern being used?

Sure

src/libs/NetworkState.ts (via useNetwork) offline/reconnect state

src/libs/RevealedCardSecretsStore.ts already a small factory (createRevealedSecretStore<T>), 2 instances (card PIN + virtual-card details)

src/components/Navigation/SearchSidebarCollapseStore.ts sidebar peek state

src/libs/AgentZeroReasoningStore.ts and src/libs/AgentZeroOptimisticStore.ts (both via useAgentZeroStatusIndicator) keyed reasoning/optimistic stores

src/components/Charts/utils/chartFontsCache.ts (via useChartFonts) loaded-fonts cache

src/components/Overlay/libs/dismissableLayerStore.ts + overlayStore.ts this PR

After more depth look the other 4 are bridging an external event source rather than an in-memory store (so a store helper wouldn't apply) imo

…erlay-foundation

…d depth field

…erlay-foundation

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70878ba224

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…rs default export

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28f76abb51

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-02T08:00:30Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: c12074baa9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…erlay-foundation

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b731e8c2d8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 274b2a518d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-07-02T19:24:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65b414b41d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-02T19:34:45Z

+};
+
+function FloatingHost({isOpen, anchor, anchorRect, alignment, offsetPx, fadeDuration, onDismiss, onExitComplete, surfaceStyle, stackId, containFocus = false, children}: FloatingHostProps) {
+    const {style: positionStyle, available, isPositioned, onContentLayout} = useAnchoredPosition({anchorRect, alignment, offsetPx});


Preserve the anchor while the popover exits

When consumers follow the documented pattern and clear the popover state in onDismiss, isOpen becomes false and anchorRect becomes null while Presence still keeps the surface mounted for the exit animation. Passing that live anchorRect into useAnchoredPosition makes it return the hidden top-left style (opacity: 0), so the parent wrapper hides/jumps the popover before AnimatedSurface can visibly fade it out. Keep the last measured anchor/position through the unmount-suspended phase, or otherwise avoid applying the measurement gate during exit.

Useful? React with 👍 / 👎.

refactor: introduce shared Overlay primitives

c9bb15f

TaduJR requested review from a team as code owners June 21, 2026 13:13

melvin-bot Bot assigned TaduJR Jun 21, 2026

melvin-bot Bot requested review from heyjennahay and linhvovan29546 and removed request for a team and heyjennahay June 21, 2026 13:13

melvin-bot Bot requested review from a team and trjExpensify and removed request for a team June 21, 2026 13:13

github-actions Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread src/components/Overlay/hooks/useAriaHideSiblings/index.web.ts Outdated

This comment was marked as resolved.

Sign in to view

fix(Overlay): apply codex feedback

95b790b

This comment was marked as resolved.

Sign in to view

fix(Overlay): apply codex feedback (round 2)

9540d0a

This comment was marked as resolved.

Sign in to view

fix(Overlay): apply codex feedback (round 3)

af9bc4a

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

roryabraham requested review from roryabraham and removed request for trjExpensify June 25, 2026 18:54

TaduJR added 2 commits June 27, 2026 13:48

docs: add foundation README

8a34731

docs: fix README spelling

df7b478

linhvovan29546 suggested changes Jun 30, 2026

View reviewed changes

linhvovan29546 reviewed Jul 1, 2026

View reviewed changes

TaduJR added 5 commits July 1, 2026 23:47

Merge branch 'main' of https://github.com/TaduJR/App into refactor-ov…

7c04516

…erlay-foundation

refactor: instant web fade, useWindowDimensions, prop JSDoc, drop dea…

b05ea7d

…d depth field

refactor: drop dead machinery

b2866a4

refactor: inline stores, remove createExternalStore factory

7c2c191

Merge branch 'main' of https://github.com/TaduJR/App into refactor-ov…

70878ba

…erlay-foundation

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/hooks/useControlledState.ts Outdated

Comment thread src/components/Overlay/hooks/useAriaHideSiblings/index.web.ts Outdated

fix: controlled-state retry, aria-hide inert restore, and portalMarke…

28f76ab

…rs default export

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/components/Overlay/FloatingHost.tsx

Comment thread src/components/Overlay/DismissableLayer/index.web.tsx Outdated

fix: suppress FloatingLayer outside-click dismissal while covered

c12074b

This comment was marked as resolved.

Sign in to view

Merge branch 'main' of https://github.com/TaduJR/App into refactor-ov…

b731e8c

…erlay-foundation

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/components/Overlay/DismissableLayer/index.web.tsx

fix: use box-none on overlay hosts so children stay interactive

274b2a5

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/components/Overlay/Portal/index.tsx

fix: support all orientations on the native Portal modal

65b414b

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Uh oh!

Conversation

TaduJR commented Jun 21, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 21, 2026

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

codecov Bot commented Jun 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

linhvovan29546 commented Jun 22, 2026

Uh oh!

roryabraham commented Jun 25, 2026

Uh oh!

TaduJR commented Jun 27, 2026

Uh oh!

TaduJR commented Jun 29, 2026

Uh oh!

linhvovan29546 commented Jun 30, 2026

Uh oh!

linhvovan29546 commented Jun 30, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linhvovan29546 Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

TaduJR Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

TaduJR Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

chatgpt-codex-connector Bot commented Jul 2, 2026

codecov Bot commented Jun 21, 2026 •

edited by github-actions Bot

Loading