[CP Staging] Revert "Open linked message at top"#94470
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92e2cff605
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| requestAnimationFrame(() => { | ||
| setIsInitialRender(false); | ||
| requestAnimationFrame(() => setHasLinkingSettled(true)); |
There was a problem hiding this comment.
Preserve the linked-message anchor while loading
When opening a report to a linked/unread action that is already cached while OpenReport is still loading, this second RAF marks the handoff as settled and disables MVCP after only two frames. Since ReportActionsList no longer holds the skeleton during reportLoadingState.isLoadingInitialReportActions, the initial response can still merge adjacent actions after this point; those insertions are no longer anchored and can shift the target message out of view. Please keep the anchor/skeleton active until the initial report actions load completes.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
📲 Install BuildsAndroid
|
…ure/open-linked-message-centered [CP Staging] Revert "Open linked message at top" (cherry picked from commit b9c9d62) (cherry-picked to staging by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.18-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR ([CP Staging] Revert "Open linked message at top") reverts Expensify/App#93403 and only touches internal frontend rendering logic — I searched @mountiny, since no documented behavior changed, no help site PR was opened. If you believe a help article should be updated here, let me know and I'll create one. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.19-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.21-2 🚀
|
Reverts #93403
Fixed issues
$ #94402