Skip to content

[CP Staging] Revert "Open linked message at top"#94470

Merged
mountiny merged 1 commit into
mainfrom
revert-93403-VickyStash/feature/open-linked-message-centered
Jun 24, 2026
Merged

[CP Staging] Revert "Open linked message at top"#94470
mountiny merged 1 commit into
mainfrom
revert-93403-VickyStash/feature/open-linked-message-centered

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Reverts #93403

Fixed issues

$ #94402

@mountiny mountiny self-assigned this Jun 24, 2026
@mountiny mountiny requested review from a team as code owners June 24, 2026 14:27
@melvin-bot melvin-bot Bot requested review from aimane-chnaif and flaviadefaria and removed request for a team June 24, 2026 14:27
@melvin-bot

melvin-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92e2cff605

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


requestAnimationFrame(() => {
setIsInitialRender(false);
requestAnimationFrame(() => setHasLinkingSettled(true));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the linked-message anchor while loading

When opening a report to a linked/unread action that is already cached while OpenReport is still loading, this second RAF marks the handoff as settled and disables MVCP after only two frames. Since ReportActionsList no longer holds the skeleton during reportLoadingState.isLoadingInitialReportActions, the initial response can still merge adjacent actions after this point; those insertions are no longer anchored and can shift the target message out of view. Please keep the anchor/skeleton active until the initial report actions load completes.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 94.11% <ø> (ø)
...c/components/FlashList/InvertedFlashList/index.tsx 100.00% <100.00%> (ø)
src/pages/inbox/report/ReportActionsList.tsx 79.28% <100.00%> (+1.82%) ⬆️
src/components/FlashList/useFlashListScrollKey.ts 94.11% <94.11%> (ø)
... and 11 files with indirect coverage changes

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mountiny mountiny merged commit b9c9d62 into main Jun 24, 2026
49 of 50 checks passed
@mountiny mountiny deleted the revert-93403-VickyStash/feature/open-linked-message-centered branch June 24, 2026 14:43
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@sentry

sentry Bot commented Jun 24, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Expensify org.me.mobiexpensifyg 9.4.18-0 (509041800) Release

⚙️ app Build Distribution Settings

OSBotify pushed a commit that referenced this pull request Jun 24, 2026
…ure/open-linked-message-centered

[CP Staging] Revert "Open linked message at top"

(cherry picked from commit b9c9d62)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 24, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.18-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR ([CP Staging] Revert "Open linked message at top") reverts Expensify/App#93403 and only touches internal frontend rendering logic — FlashList scroll-key handling, a removed patch, and ReportActionsList — to change where a chat scrolls when opening a linked message. It does not add, remove, or change any user-facing feature, setting, label, or flow that's documented on the help site.

I searched App/docs/articles for any content covering linked-message / scroll-to-message behavior and found nothing that describes this, so there's nothing to update. No draft PR was created.

@mountiny, since no documented behavior changed, no help site PR was opened. If you believe a help article should be updated here, let me know and I'll create one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.19-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@VickyStash VickyStash mentioned this pull request Jun 26, 2026
52 tasks
JS00001 pushed a commit that referenced this pull request Jun 26, 2026
…ash/feature/open-linked-message-centered"

This reverts commit b9c9d62, reversing
changes made to abb2cfc.
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.21-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants