Exclude all-pending card reports from the Submit to-do

[ishpaul777]

Explanation of Change

Workspace expense reports whose only expense is a pending (unposted) Expensify Card transaction were being counted in the "Submit" to-do and shown a Submit button, even though such a report can't be submitted until the transaction posts (its own next-steps text already says so).

The to-do buckets are classified by isSubmitAction in src/libs/ReportPrimaryActionUtils.ts. Its hasNoSubmittableTransaction guard already excluded reports whose transactions are all scanning / smartscan-failed, but it did not account for all-pending reports. The sibling isApproveAction in the same file already excludes all-pending reports, so Submit was inconsistent with Approve.

This adds isPending(transaction) to the hasNoSubmittableTransaction check. Because all four surfaces (Home/For You tile, Inbox/Search "Submit" badge, Spend count, and the report-level Submit button) derive from this single predicate, one change fixes all of them.

This is the same family of bug as #637331 (all-held reports), but for pending card transactions. The server-side parallel is handled in a companion Auth PR so the prefetched Search snapshot agrees with the client.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/653982
PROPOSAL:

Tests

1. Set up a Collect/Control workspace where you are the submitter, with an Expensify Card.
2. Create a workspace expense report whose only expense is a pending (unposted) card transaction (still pending, not yet posted).
3. Open NewDot Home (For You): verify the report is not counted in the "Submit" tile.
4. Open Inbox and the Search type-menu: verify the "Submit" badge does not count the report.
5. Open the Spend tab: verify the report is not included in the Submit count.
6. Open the report itself: verify no Submit button is offered and next-steps says the transaction is still pending.
7. Add a second, normal (posted) expense to the same report and verify the report is now submittable (Submit prompt/button reappear), confirming only all-pending reports are excluded.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests. The to-do counts are derived locally from Onyx data (ONYXKEYS.DERIVED.TODOS), so the pending report should be excluded from the Submit to-do while offline as well.

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• I verified there are no console errors

Screenshots/Videos

MacOS: Chrome / Safari

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 470f99d5f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Keep Submit visible for non-card pending expenses

When an open report contains a pending cash/manual transaction (a transaction with status: PENDING but no Expensify-card metadata), this isPending() check makes hasNoSubmittableTransaction true and removes the Submit primary action/to-do. Other submit entry points only block hasOnlyPendingCardTransactions(...), and the existing ReportPrimary/Secondary action tests treat pending non-card transactions as submittable, so this should gate pending status on card transactions instead of all pending transactions.

Useful? React with 👍 / 👎.