Resolve OOM crash for high-traffic accounts caused by retryParams

[QichenZhu]

Explanation of Change

This PR removes retryParams from the expense creation flow to resolve an OOM crash for high-traffic accounts. retryParams is dead code since we removed the retry link as part of issue #80905 via PR #82139.

Fixed Issues

$ #93846
PROPOSAL:

Tests

This PR focuses on resolving the Sentry crash on iOS HybridApp only. For other platforms, just test the normal expense creation flow.

Precondition: download the HEIC image from #68778 (comment), duplicate it 30 copies, and import them into iPhone 17

1. Log in to a high-traffic account
2. Tap the floating scan button
3. Tap the image picker icon
4. Tap Choose file
5. Select the 30 images and confirm
6. Finish the expense creation flow
7. Verify the app doesn't crash

• Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

Before

before.mov

After

after.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

mac-web.mov

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU/MoneyRequestBuilder.ts	90.09% <ø> (ø)
src/libs/actions/IOU/TrackExpense.ts	81.22% <ø> (-0.34%)	⬇️
... and 46 files with indirect coverage changes

[QichenZhu]

@mountiny, since @dilshodmackbook-sketch said he doesn't have enough bandwidth to work on #95663, I took over the implementation. Could you take a look?

Before

before.mov

After

after.mov

Based on the comparison videos, this fixes part of the issue: after clicking create expense, memory usage is lower than before, and the app doesn't crash at that step. However, some users can still experience a crash before that step, which has a separate cause that #94976 aims to fix.

[mountiny]

@QichenZhu Can you give more explanation to why removing a dead code fixes an issue? that does not make much sense to me

[QichenZhu]

@mountiny retryParams is set but not read. It is in failureData and contains a huge amount of data including personalDetails for each expense. When creating 30 expenses at once, all 30 of these massive payloads live in memory simultaneously.

[mountiny]

Ah ok got it, thank you! Can you make the pr ready for a review?

[melvin-bot]

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]