Replace user-facing "Magic code" copy with "Security code"#96181
Replace user-facing "Magic code" copy with "Security code"#96181MelvinBot wants to merge 2 commits into
Conversation
Co-authored-by: Lauren <laurenreidexpensify@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Lauren <laurenreidexpensify@users.noreply.github.com>
|
Fixed the failing Oxfmt check and pushed to the branch. What was failing: explanation:
'Face/fingerprint or passkey verification are enabled on one or more devices. Revoking access will require a security code for the next verification on that device.',I ran oxfmt Still red — but not code-related: the |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (137KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
👋 I looked into the failing checks. The only check that's actually failing is PR Author Checklist / Why it fails: the check reports Why there's no code fix: this PR only changes To make it green: the author checklist is meant to be completed by a human author, so I didn't auto-tick it. Please review and check the boxes in the PR description (or confirm you'd like me to). It won't block review or merge either way. |
|
Following up — the status is unchanged, and there's still no code fix to push. The single red check is PR Author Checklist / To turn it green: the author checklist is a human-author responsibility (it attests to manual testing/QA), so I can't complete it on your behalf. Please review and tick the boxes in the PR description. Once they're checked, the |
|
@NikkiWines @chuckdries could you take a look here when you have a moment? This PR is now just focused on the front end copy, but it feels like we should probably also change the constants - eg Line 129 in 4c928c1 do you see any reason why we couldn't update |
|
@laurenreidexpensify yeah |
|
Noting here that we have a bunch of components and files that use Those should all use our internal term, However, to keep things simpler, let's update the user-facing copy to use thoughts cc: @laurenreidexpensify @chuckdries |
|
I agree, let's tackle the user facing localization strings separately from renaming all the source code files and constants, since doing that refactor is riskier and has no user-visible benefit |
Explanation of Change
This is a front-end copy-only change: it renames every user-facing "Magic code" reference to "Security code" across NewDot (sign-in, onboarding, one-time verification gates, per-action confirmations, and error messages).
Per the internationalization workflow,
src/languages/en.tsis the single source of truth and every other locale file is auto-generated. So this PR edits onlysrc/languages/en.ts(26 string values). TheGenerate static translationsworkflow runs automatically on PRs that touchen.tsand will regeneratede/es/fr/it/ja/nl/pl/pt-BR/zh-hansfrom the updated English source.Only string values were changed — translation keys (
magicCode,enterMagicCode, etc.), routes (.../confirm-magic-code), component names (MagicCodeInput), and code identifiers are intentionally left unchanged, since those are not user-facing and changing them would be a behavior change (out of scope).Fixed Issues
$ #96180
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari