Fix - w27-BA- IBAN does not appear in the confirmation page, Auth CreateCorpayBankAccount error shown#96201
Open
FitseTLT wants to merge 2 commits into
Conversation
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
July 15, 2026 16:47
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-16.at.7.33.05.AM.movAndroid: mWeb ChromeScreen_Recording_20260716_072216_Chrome.mp4iOS: HybridAppScreen.Recording.2026-07-16.at.7.52.12.AM.moviOS: mWeb SafariScreen.Recording.2026-07-16.at.7.59.10.AM.movMacOS: Chrome / SafariScreen.Recording.2026-07-16.at.7.11.45.AM.mov |
Contributor
|
@FitseTLT, could you please merge the main? thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On the manual (non-USD) bank account flow, the account-holder address autocomplete (
AddressSearchinAccountHolderDetails) remappedstreet/cityto the account-holder fields but leftcountryunmapped. Unmapped keys are written verbatim, so picking the account holder's address wrote its country into the genericcountrydraft key — which is the bank's country. That made the Corpay schema-refetch effect (keyed on the bankcountry) load the wrong country's schema, one without an IBAN field, so the IBAN disappeared from the confirmation page and theCreateCorpayBankAccountrequest failed.This PR remaps the address
countrytoaccountHolderCountry, its correct field, so the write no longer corrupts the bank country (which stays the value selected in the earlier, mandatory Country step). The Corpay schema keeps its IBAN field, the IBAN shows on the confirmation page, and the account holder's country is auto-populated from the picked address.accountHolderCountrydoes not drive the schema fetch, so writing it is safe.Fixed Issues
$ #95309
PROPOSAL: #95309 (comment)
Tests
Precondition: Be admin of a workspace with EUR currency
Aland Islandsenter an address, and proceed to the confirmation pageOffline tests
Bank-account creation requires the Corpay/Auth backend, so this flow isn't exercised offline. No offline-specific behavior is changed by this PR.
QA Steps
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-07-16.16-40-45.mp4
Android: mWeb Chrome
2026-07-15.20-02-59.mp4
iOS: Native
2026-07-16.17-19-23.mp4
iOS: mWeb Safari
2026-07-15.20-00-10.mp4
MacOS: Chrome / Safari
2026-07-15.19-51-38.mp4