Skip to content

iOS - Expense - Failed submission error is not displayed when network request fails #96222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorretheboy wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

iOS - Expense - Failed submission error is not displayed when network request fails #96222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ function MoneyRequestReportTransactionItemBody({
return (
<OfflineWithFeedback
pendingAction={pendingAction}
errors={transaction.errors}

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire receipt-error dismissal in transaction rows

When transaction.errors contains a receipt-upload error, ErrorMessageRow/DotIndicatorMessage renders the receipt failure UI with a “Delete expense” button and invokes dismissError; this new OfflineWithFeedback passes those errors but no dismissError or onClose, so that button falls back to the no-op default. In the failed receipt submission case now surfaced in this report table, users can see the delete action but tapping it from the row will not clear/delete the failed expense.

Useful? React with 👍 / 👎.

errorRowStyles={[styles.ph3, styles.pb2]}
style={!shouldUseNarrowLayout && isLastItem && [styles.tableBottomRadius, styles.overflowHidden]}
>
<PressableWithFeedback
Expand Down
Loading