Allow clearing the Default Vendor by re-selecting it by Beamanator · Pull Request #96227 · Expensify/App

Beamanator · 2026-07-15T22:51:49Z

Explanation of Change

Once a Default Vendor was set on any accounting integration's export config, there was no way to unselect it — tapping the currently-selected row was a silent no-op that just navigated back. This blocked vendor-matching CC beta testers who needed to reset workspaces between test scenarios (and it's been latent for every workspace that has ever set a Default Vendor).

This change drops the if (row.value !== currentVendor) guard on all five Default Vendor selector pages. Re-tapping the currently-selected row now sends a clear value to the backend and navigates back:

QBO (shared bill + credit-card page) and QBD send CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE, matching the sentinel these fields already accept via bulk config paths.
Sage Intacct, Certinia, and NetSuite send '' (empty string) — those fields hold raw vendor IDs with no NONE sentinel.

Note: the dedicated UPDATE_*_DEFAULT_VENDOR single-field backend commands need to accept the clear value. QBD/QBO-bill have partial precedent (via bulk config paths); the QBO credit-card, Sage, Certinia, and NetSuite single-field commands don't have prior clear-value calls to confirm against. This should be verified on the backend before merging.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/659748
PROPOSAL: https://github.com/Expensify/Expensify/issues/659748#issuecomment-4985966633

Tests

Open a workspace with any accounting integration connected (QBO, Sage Intacct, Certinia, NetSuite, or QBD).
Configure the integration's non-reimbursable export destination to something that uses a Default Vendor (e.g. QBO Non-reimbursable → Vendor Bill or Credit Card).
Navigate to the Default Vendor row and select any vendor.
Return to the Default Vendor row and tap the currently-selected vendor.
Verify the vendor is now cleared (the row shows no selected vendor, and re-opening the selector shows no row highlighted).
Repeat for each of the 5 affected integrations: QBO (bill + credit card), QBD, Sage Intacct (reimbursable + non-reimbursable), Certinia, NetSuite.

Verify that no errors appear in the JS console

Offline tests

Set a Default Vendor while online.
Turn off network connection.
Tap the currently-selected vendor.
Verify the row updates optimistically to a cleared state.
Turn network back on and verify the change persists.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Tapping the currently-selected vendor on any accounting integration's Default Vendor selector now clears it. Previously the guarded update call skipped this case, leaving no path to unset the field from the UI. QBO and QBD send CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE; Sage Intacct, Certinia, and NetSuite send an empty string. Fixes Expensify/Expensify#659748

melvin-bot · 2026-07-15T22:51:54Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-15T22:56:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...sDesktopNonReimbursableDefaultVendorSelectPage.tsx	`0.00% <0.00%> (ø)`
...port/QuickbooksNonReimbursableVendorSelectPage.tsx	`0.00% <0.00%> (ø)`
...cct/export/DynamicSageIntacctDefaultVendorPage.tsx	`0.00% <0.00%> (ø)`
.../DynamicNetSuiteExportExpensesVendorSelectPage.tsx	`0.00% <0.00%> (ø)`
...ting/certinia/export/CertiniaDefaultVendorPage.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

github-actions · 2026-07-15T22:57:05Z

-        if (row.value !== exportConfig?.vendorAccount && policyID) {
-            updateFinancialForceDefaultVendor(policyID, row.value, exportConfig?.vendorAccount ?? null);
+        if (policyID) {
+            const newValue = row.value === exportConfig?.vendorAccount ? '' : row.value;


❌ CONSISTENCY-2 (docs)

The bare empty string '' is used as a magic sentinel to represent "no vendor / deselected". It is not self-explanatory and it is inconsistent with the sibling changes in this same PR (QBO and QBD) which use the named constant CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE for the identical "cleared vendor" concept.

Use a named/documented value instead of the bare literal, e.g.:

const newValue = row.value === exportConfig?.vendorAccount ? CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE : row.value;

or, if the backend requires an empty string here, extract a clearly-named constant documenting that '' means "no default vendor".

Reviewed at: f037fc3 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

from Alex's Claude agent

Fair — the bare '' was inconsistent with the QBO/QBD sites. Extracted a local, self-documenting CLEAR_DEFAULT_VENDOR constant per file (with a comment noting the backend uses a raw vendor ID, not the NONE sentinel used by QBO/QBD). Using CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE would be semantically wrong for these backends per MelvinBot's plan review.

Fixed in 9c7dcfd.

github-actions · 2026-07-15T22:57:06Z

-            if (value !== defaultVendor) {
-                updateSageIntacctDefaultVendor(policyID, settingName, value, defaultVendor);
-            }
+            const newValue = value === defaultVendor ? '' : value;


❌ CONSISTENCY-2 (docs)

The bare empty string '' is used as a magic sentinel to represent the "deselected / cleared" vendor. It is not self-explanatory and is inconsistent with the sibling changes in this PR (QBO and QBD) which use the named constant CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE for the same concept.

Replace the literal with a named/documented value, e.g.:

const newValue = value === defaultVendor ? CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE : value;

or extract a clearly-named constant documenting that '' means "no default vendor" if the empty string is what the Sage Intacct backend expects.

Reviewed at: f037fc3 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

from Alex's Claude agent

Fair — the bare '' was inconsistent with the QBO/QBD sites. Extracted a local, self-documenting CLEAR_DEFAULT_VENDOR constant per file (with a comment noting the backend uses a raw vendor ID, not the NONE sentinel used by QBO/QBD). Using CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE would be semantically wrong for these backends per MelvinBot's plan review.

Fixed in 9c7dcfd.

github-actions · 2026-07-15T22:57:08Z

-            if (config?.defaultVendor !== value && policyID) {
-                updateNetSuiteDefaultVendor(policyID, value, config?.defaultVendor);
+            if (policyID) {
+                const newValue = value === config?.defaultVendor ? '' : value;


❌ CONSISTENCY-2 (docs)

The bare empty string '' is used as a magic sentinel for the "deselected / cleared" vendor value. It is not self-explanatory and is inconsistent with the sibling changes in this PR (QBO and QBD) which use the named constant CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE for the identical "cleared vendor" concept.

Replace the literal with a named/documented value, e.g.:

const newValue = value === config?.defaultVendor ? CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE : value;

or extract a clearly-named constant documenting that '' means "no default vendor" if the NetSuite backend requires the empty string.

Reviewed at: f037fc3 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

from Alex's Claude agent

Fair — the bare '' was inconsistent with the QBO/QBD sites. Extracted a local, self-documenting CLEAR_DEFAULT_VENDOR constant per file (with a comment noting the backend uses a raw vendor ID, not the NONE sentinel used by QBO/QBD). Using CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE would be semantically wrong for these backends per MelvinBot's plan review.

Fixed in 9c7dcfd.

Beamanator · 2026-07-15T22:59:55Z

@codex review

chatgpt-codex-connector · 2026-07-15T23:05:05Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: f037fc3d1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Beamanator · 2026-07-15T23:46:45Z

@codex review

chatgpt-codex-connector · 2026-07-15T23:50:30Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 9c7dcfdcec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1 · 2026-07-16T05:56:57Z

Hi @Beamanator, let me know when this is ready for review, thank you!

Beamanator requested review from a team as code owners July 15, 2026 22:51

melvin-bot Bot assigned Beamanator Jul 15, 2026

melvin-bot Bot requested a review from Eskalifer1 July 15, 2026 22:51

melvin-bot Bot requested review from trjExpensify and removed request for a team July 15, 2026 22:51

github-actions Bot reviewed Jul 15, 2026

View reviewed changes

Beamanator added the InternalQA This pull request required internal QA label Jul 15, 2026

Replace bare '' with named CLEAR_DEFAULT_VENDOR constant

9c7dcfd

Uh oh!

Conversation

Beamanator commented Jul 15, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

codecov Bot commented Jul 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot Jul 15, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

Beamanator Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

Beamanator Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

Beamanator Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Beamanator commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 15, 2026

Uh oh!

Beamanator commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 15, 2026

Uh oh!

Eskalifer1 commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading