Shrink Book a call avatar to match phone icon size#96233
Open
c3024 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Coming from here, does this avatar size look okay?
|
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Contributor
Author
That is likely because I don't have a real user account assigned to an account manager, so I seeded data for an account with an account manager in the development database. That data may be missing from this local database. These PRs didn't touch that functionality. Testing the ad hoc build with a real user who is assigned an account manager should show the banner correctly. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation of Change
Follow-up to design feedback on the Book a call PR: the account manager avatar shown beside the "Book a call" text was too large. This shrinks it from
AVATAR_SIZE.SMALL(28px) toAVATAR_SIZE.MID_SUBSCRIPT(16px) so it matches the phone-icon variant's size (also 16px) and sits at roughly text height.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/650433
PROPOSAL:
Tests
Offline tests
This change is purely presentational; there is no offline-specific behavior. The button and avatar render the same regardless of network state.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari