clean up

Author: kubabutkiewicz

lib/OnyxCache.ts

@@ -84,7 +84,6 @@ class OnyxCache {
             'addLastAccessedKey',
             'addAllSafeEvictionKeysToRecentlyAccessedList',
             'getKeyForEviction',
-            'getRecentKeysSize',
         );
     }
 
@@ -247,7 +246,6 @@ class OnyxCache {
         const iterator = this.recentKeys.values();
         const safeKeysToRemove: OnyxKey[] = [];
 
-        // First pass: identify safe keys to evict that aren't the most recently added key
         const recentKeysArray = Array.from(this.recentKeys);
         const mostRecentKey = recentKeysArray[recentKeysArray.length - 1];
 
@@ -262,12 +260,7 @@ class OnyxCache {
             iterResult = iterator.next();
         }
 
-        // Even if we don't have enough safe keys to evict, remove all available safe keys
-        // This will get us as close as possible to the target size without removing the most recent key
-        const keysToRemove = safeKeysToRemove;
-
-        // Remove the identified keys from cache
-        keysToRemove.forEach((key) => {
+        safeKeysToRemove.forEach((key) => {
             delete this.storageMap[key];
             this.recentKeys.delete(key);
         });
@@ -364,11 +357,6 @@ class OnyxCache {
     getKeyForEviction(): OnyxKey | undefined {
         return this.recentlyAccessedKeys.find((key) => !this.evictionBlocklist[key]);
     }
-
-    /** Get the size of the recentKeys set */
-    getRecentKeysSize(): number {
-        return this.recentKeys.size;
-    }
 }
 
 const instance = new OnyxCache();

tests/unit/onyxCacheTest.tsx

@@ -808,10 +808,6 @@ describe('Onyx', () => {
 
                     // The trigger key should be in cache as it was just connected
                     expect(cache.hasCacheForKey(triggerKey)).toBe(true);
-
-                    // The cache size should exceed the configured limit (2) since
-                    // we can't remove non-evictable keys
-                    expect(cache.getRecentKeysSize()).toBeGreaterThan(2);
                 });
         });
     });