Cleanup

Author: fabioh8010

.github/workflows/reassurePerfTests.yml

@@ -24,30 +24,22 @@ jobs:
         with:
           node-version-file: '.nvmrc'
 
-      # - name: Install dependencies
-      #   run: npm install
+      - name: Install dependencies
+        run: npm install
 
-      # - name: Run Reassure baseline tests
-      #   run: npx reassure --baseline --verbose
+      - name: Run Reassure baseline tests
+        run: npx reassure --baseline --verbose
 
-      # - name: Checkout PR head SHA
-      #   run: |
-      #     git fetch origin ${{ github.event.pull_request.head.sha }} --no-tags --depth=1
-      #     git switch --force --detach ${{ github.event.pull_request.head.sha }}
-          
-      # - name: Reinstall dependencies
-      #   run: npm install --force
-
-      # - name: Run Reassure delta tests
-      #   run: npx reassure --branch --verbose
-      - name: Run Reassure tests
+      - name: Checkout PR head SHA
         run: |
-          npm install --force || (rm -rf node_modules && npm install --force)
-          npx reassure --baseline --verbose
           git fetch origin ${{ github.event.pull_request.head.sha }} --no-tags --depth=1
           git switch --force --detach ${{ github.event.pull_request.head.sha }}
-          npm install --force || (rm -rf node_modules && npm install --force)
-          npx reassure --branch --verbose
+          
+      - name: Reinstall dependencies
+        run: npm install --force
+
+      - name: Run Reassure delta tests
+        run: npx reassure --branch --verbose
 
       - name: Upload Reassure results
         uses: actions/upload-artifact@v4

jest-sequencer.js

@@ -1,5 +1,8 @@
 const Sequencer = require('@jest/test-sequencer').default;
 
+/**
+ * Makes all unit tests run ordered by their path, reducing flakiness on Reassure.
+ */
 class TestSequencer extends Sequencer {
     shard(tests, {shardIndex, shardCount}) {
         const shardSize = Math.ceil(tests.length / shardCount);

lib/Onyx.ts

@@ -73,7 +73,7 @@ function init({
 
     OnyxUtils.initStoreValues(keys, initialKeyStates, evictableKeys, fullyMergedSnapshotKeys);
 
-    // Initialize all of our keys with data provided then give green light to any pending connections........
+    // Initialize all of our keys with data provided then give green light to any pending connections
     Promise.all([cache.addEvictableKeysToRecentlyAccessedList(OnyxUtils.isCollectionKey, OnyxUtils.getAllKeys), OnyxUtils.initializeWithDefaultKeyStates()]).then(
         OnyxUtils.getDeferredInitTask().resolve,
     );

lib/OnyxUtils.ts

@@ -1450,6 +1450,9 @@ function updateSnapshots(data: OnyxUpdate[], mergeFn: typeof Onyx.merge): Array<
     return promises;
 }
 
+/**
+ * Clear internal variables used in this file, useful in test environments.
+ */
 function clearOnyxUtilsInternals() {
     mergeQueue = {};
     mergeQueuePromise = {};