fix: preserve array reference stability in removeNestedNullValues

Author: fabioh8010

lib/utils.ts

@@ -186,14 +186,10 @@ function isMergeableObject<TObject extends Record<string, unknown>>(value: unkno
 
 /** Deep removes the nested null values from the given value. Returns the original reference if no nulls were found. */
 function removeNestedNullValues<TValue extends OnyxInput<OnyxKey> | null>(value: TValue): TValue {
-    if (value === null || value === undefined || typeof value !== 'object') {
+    if (value === null || value === undefined || typeof value !== 'object' || Array.isArray(value)) {
         return value;
     }
 
-    if (Array.isArray(value)) {
-        return [...value] as TValue;
-    }
-
     let hasChanged = false;
     const result: Record<string, unknown> = {};
 

tests/unit/utilsTest.ts

@@ -319,5 +319,19 @@ describe('fastMerge', () => {
             expect(result).not.toBe(value);
             expect((result as Record<string, unknown>).a).toBe(sibling);
         });
+
+        it('should return the same array reference', () => {
+            const arr = [1, 2, 3];
+            const result = utils.removeNestedNullValues(arr);
+            expect(result).toBe(arr);
+        });
+
+        it('should return the same reference for objects containing arrays', () => {
+            const arr = ['a', 'b'];
+            const value = {items: arr, count: 2};
+            const result = utils.removeNestedNullValues(value);
+            expect(result).toBe(value);
+            expect((result as Record<string, unknown>).items).toBe(arr);
+        });
     });
 });