Remove duplicate code

Author: iwiznia

lib/Onyx.js

@@ -7,6 +7,7 @@ import Storage from './storage';
 import * as Logger from './Logger';
 import cache from './OnyxCache';
 import createDeferredTask from './createDeferredTask';
+import customizerForMergeWith from "./customizerForMergeWith";
 
 // Keeps track of the last connectionID that was used so we can keep incrementing it
 let lastConnectionID = 0;
@@ -636,24 +637,6 @@ function hasPendingMergeForKey(key) {
     return Boolean(mergeQueue[key]);
 }
 
-/**
- * When merging 2 objects into onyx that contain an array, we want to completely replace the array instead of the default
- * behavior which is to merge each item by its index.
- * ie:
- * merge({a: [1]}, {a: [2,3]}):
- *  - In the default implementation would produce {a:[1,3]}
- *  - With this function would produce: {a: [2,3]}
- * @param {*} objValue
- * @param {*} srcValue
- * @return {*}
- */
-// eslint-disable-next-line rulesdir/prefer-early-return
-function customizerForMergeWith(objValue, srcValue) {
-    if (_.isArray(objValue)) {
-        return srcValue;
-    }
-}
-
 /**
  * Given an Onyx key and value this method will combine all queued
  * value updates and return a single value. Merge attempts are

lib/OnyxCache.js

@@ -1,5 +1,6 @@
 import _ from 'underscore';
 import lodashMergeWith from 'lodash/mergeWith';
+import customizerForMergeWith from "./customizerForMergeWith";
 
 const isDefined = _.negate(_.isUndefined);
 
@@ -105,20 +106,12 @@ class OnyxCache {
         delete this.storageMap[key];
     }
 
-    // eslint-disable-next-line rulesdir/prefer-early-return
-    customizerForMergeWith(objValue, srcValue) {
-        // TODO: this is duplicated from Onyx, reuse it instead
-        if (_.isArray(objValue)) {
-            return srcValue;
-        }
-    }
-
     /**
      * Deep merge data to cache, any non existing keys will be created
      * @param {Record<string, *>} data - a map of (cache) key - values
      */
     merge(data) {
-        this.storageMap = lodashMergeWith({}, this.storageMap, data, this.customizerForMergeWith);
+        this.storageMap = lodashMergeWith({}, this.storageMap, data, customizerForMergeWith);
 
         const storageKeys = this.getAllKeys();
         const mergedKeys = _.keys(data);

lib/storage/providers/LocalForage.js

@@ -8,19 +8,12 @@ import localforage from 'localforage';
 import _ from 'underscore';
 import lodashMergeWith from 'lodash/mergeWith';
 import SyncQueue from '../../SyncQueue';
+import customizerForMergeWith from "../../customizerForMergeWith";
 
 localforage.config({
     name: 'OnyxDB',
 });
 
-// eslint-disable-next-line rulesdir/prefer-early-return
-const customizerForMergeWith = function (objValue, srcValue) {
-    // TODO: this is duplicated from Onyx, reuse it instead
-    if (_.isArray(objValue)) {
-        return srcValue;
-    }
-};
-
 const provider = {
     /**
      * Writing very quickly to IndexedDB causes performance issues and can lock up the page and lead to jank.