Skip to content

Commit 8d65989

Browse files
committed
fix ts
1 parent 4c77804 commit 8d65989

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

lib/useOnyx.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,7 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
143143
const previousCollectionKey = OnyxUtils.splitCollectionMemberKey(previousKey)[0];
144144
const collectionKey = OnyxUtils.splitCollectionMemberKey(key)[0];
145145

146-
if (
147-
OnyxUtils.isCollectionMemberKey(previousCollectionKey, previousKey, previousCollectionKey.length) &&
148-
OnyxUtils.isCollectionMemberKey(collectionKey, key, collectionKey.length) &&
149-
previousCollectionKey === collectionKey
150-
) {
146+
if (OnyxUtils.isCollectionMemberKey(previousCollectionKey, previousKey) && OnyxUtils.isCollectionMemberKey(collectionKey, key) && previousCollectionKey === collectionKey) {
151147
return;
152148
}
153149
} catch (e) {

tests/perf-test/OnyxUtils.perf-test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,12 @@ describe('OnyxUtils', () => {
152152
});
153153

154154
describe('isCollectionMemberKey', () => {
155-
const collectionKeyLength = collectionKey.length;
156-
157155
test('one call with correct key', async () => {
158-
await measureFunction(() => OnyxUtils.isCollectionMemberKey(collectionKey, `${collectionKey}entry1`, collectionKeyLength));
156+
await measureFunction(() => OnyxUtils.isCollectionMemberKey(collectionKey, `${collectionKey}entry1`));
159157
});
160158

161159
test('one call with wrong key', async () => {
162-
await measureFunction(() => OnyxUtils.isCollectionMemberKey(collectionKey, `${ONYXKEYS.COLLECTION.TEST_KEY_2}entry1`, collectionKeyLength));
160+
await measureFunction(() => OnyxUtils.isCollectionMemberKey(collectionKey, `${ONYXKEYS.COLLECTION.TEST_KEY_2}entry1`));
163161
});
164162
});
165163

0 commit comments

Comments
 (0)