Merge pull request #767 from callstack-internal/perf/86765-allow-selectors-to-be-gced

Julesssss · web-flow · commit bcc039529762 · 2026-04-01T11:23:57.000-07:00
perf: Change to WeakMap so selectors can be GC'ed
diff --git a/lib/OnyxSnapshotCache.ts b/lib/OnyxSnapshotCache.ts
@@ -33,7 +33,7 @@ class OnyxSnapshotCache {
 
     constructor() {
         this.snapshotCache = new Map();
-        this.selectorIDMap = new Map();
+        this.selectorIDMap = new WeakMap();
         this.selectorIDCounter = 0;
         this.cacheKeyRefCounts = new Map();
     }

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class OnyxSnapshotCache {`
`33`	`33`
`34`	`34`	`constructor() {`
`35`	`35`	`this.snapshotCache = new Map();`
`36`		`- this.selectorIDMap = new Map();`
	`36`	`+ this.selectorIDMap = new WeakMap();`
`37`	`37`	`this.selectorIDCounter = 0;`
`38`	`38`	`this.cacheKeyRefCounts = new Map();`
`39`	`39`	`}`