Address comments

Author: fabioh8010

lib/OnyxSnapshotCache.ts

@@ -64,7 +64,7 @@ class OnyxSnapshotCache {
      */
     registerConsumer<TKey extends OnyxKey, TReturnValue>(options: Pick<UseOnyxOptions<TKey, TReturnValue>, 'selector'>): string {
         const selectorID = options?.selector ? this.getSelectorID(options.selector) : 'no_selector';
-        const cacheKey = `${selectorID}`;
+        const cacheKey = String(selectorID);
 
         // Increment reference count for this cache key
         const currentCount = this.cacheKeyRefCounts.get(cacheKey) || 0;

lib/OnyxUtils.ts

@@ -817,11 +817,12 @@ function retryOperation<TMethod extends RetriableOnyxOperation>(error: Error, on
  * Notifies subscribers and writes current value to cache
  */
 function broadcastUpdate<TKey extends OnyxKey>(key: TKey, value: OnyxValue<TKey>, hasChanged?: boolean): void {
-    if (hasChanged) {
-        cache.set(key, value);
+    if (!hasChanged) {
+        return;
     }
 
-    keyChanged(key, value, () => !!hasChanged);
+    cache.set(key, value);
+    keyChanged(key, value);
 }
 
 function hasPendingMergeForKey(key: OnyxKey): boolean {

tests/unit/OnyxSnapshotCacheTest.ts

@@ -44,14 +44,10 @@ describe('OnyxSnapshotCache', () => {
             const keyWithoutSelector = cache.registerConsumer(optionsWithoutSelector);
             const keyWithUndefined = cache.registerConsumer({});
 
-            // Different option combinations should produce different cache keys
-            expect(keyWithSelector).toContain('0'); // Should contain selector ID
-            expect(keyWithoutSelector).toContain('no_selector'); // Should indicate no selector
-            expect(keyWithUndefined).toContain('no_selector'); // Should indicate no selector
-
-            // Selector key is unique; the two no-selector keys are equal
-            expect(keyWithSelector).not.toEqual(keyWithoutSelector);
-            expect(keyWithoutSelector).toEqual(keyWithUndefined);
+            // Selector cache keys are the selector ID as a string; no-selector consumers share the same key
+            expect(keyWithSelector).toBe('0');
+            expect(keyWithoutSelector).toBe('no_selector');
+            expect(keyWithUndefined).toBe('no_selector');
         });
 
         it('should store and retrieve cached results', () => {