Skip to content

Commit fa95648

Browse files
committed
remove storage mock usage from useOnyx perf tests
1 parent 3164734 commit fa95648

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

tests/perf-test/useOnyx.perf-test.tsx

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {Text, View} from 'react-native';
44
import {measureRenders} from 'reassure';
55
import type {FetchStatus, OnyxEntry, OnyxKey, OnyxValue, ResultMetadata, UseOnyxOptions} from '../../lib';
66
import Onyx, {useOnyx} from '../../lib';
7-
import StorageMock from '../../lib/storage';
87
import type {UseOnyxSelector} from '../../lib/useOnyx';
98

109
const ONYXKEYS = {
@@ -81,13 +80,13 @@ describe('useOnyx', () => {
8180
});
8281

8382
/**
84-
* Expected renders: 2.
83+
* Expected renders: 1.
8584
*/
86-
test('data in storage but not yet in cache', async () => {
85+
test('data set via Onyx.set before render', async () => {
8786
const key = ONYXKEYS.TEST_KEY;
8887
await measureRenders(<UseOnyxWrapper onyxKey={key} />, {
8988
beforeEach: async () => {
90-
await StorageMock.setItem(key, 'test');
89+
await Onyx.set(key, 'test');
9190
},
9291
scenario: async () => {
9392
await screen.findByText(dataMatcher(key, 'test'));
@@ -209,7 +208,7 @@ describe('useOnyx', () => {
209208
/>,
210209
{
211210
beforeEach: async () => {
212-
await StorageMock.setItem(key, 'test');
211+
await Onyx.set(key, 'test');
213212
},
214213
scenario: async () => {
215214
await screen.findByText(dataMatcher(key, undefined));
@@ -223,9 +222,9 @@ describe('useOnyx', () => {
223222

224223
describe('multiple calls', () => {
225224
/**
226-
* Expected renders: 2.
225+
* Expected renders: 1.
227226
*/
228-
test('3 calls loading from storage', async () => {
227+
test('3 calls loading from cache', async () => {
229228
function TestComponent() {
230229
const [testKeyData, testKeyMetadata] = useOnyx(ONYXKEYS.TEST_KEY);
231230
const [testKey2Data, testKey2Metadata] = useOnyx(ONYXKEYS.TEST_KEY_2);
@@ -254,9 +253,9 @@ describe('useOnyx', () => {
254253

255254
await measureRenders(<TestComponent />, {
256255
beforeEach: async () => {
257-
await StorageMock.setItem(ONYXKEYS.TEST_KEY, 'test');
258-
await StorageMock.setItem(ONYXKEYS.TEST_KEY_2, 'test2');
259-
await StorageMock.setItem(ONYXKEYS.TEST_KEY_3, 'test3');
256+
await Onyx.set(ONYXKEYS.TEST_KEY, 'test');
257+
await Onyx.set(ONYXKEYS.TEST_KEY_2, 'test2');
258+
await Onyx.set(ONYXKEYS.TEST_KEY_3, 'test3');
260259
},
261260
scenario: async () => {
262261
await screen.findByText(dataMatcher(ONYXKEYS.TEST_KEY, 'test'));

0 commit comments

Comments
 (0)