Skip to content

perf: improve finding matching keys in subscription #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Jun 27, 2025
Merged

perf: improve finding matching keys in subscription #645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eefa6d4
improve performacne of lookup of matching keys
TMisiukiewicz Jun 23, 2025
df39e04
Merge branch 'main' into perf/improve-matching-keys-lookup
TMisiukiewicz Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lib/OnyxUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,12 +1293,21 @@ function subscribeToKey<TKey extends OnyxKey>(connectOptions: ConnectOptions<TKe
// can send data back to the subscriber. Note that multiple keys can match as a subscriber could either be
// subscribed to a "collection key" or a single key.
const matchingKeys: string[] = [];
keys.forEach((key) => {
if (!isKeyMatch(mapping.key, key)) {
return;

// Performance optimization: For single key subscriptions, avoid O(n) iteration
if (!isCollectionKey(mapping.key)) {
if (keys.has(mapping.key)) {
matchingKeys.push(mapping.key);
}
matchingKeys.push(key);
});
} else {
// Collection case - need to iterate through all keys to find matches (O(n))
keys.forEach((key) => {
if (!isKeyMatch(mapping.key, key)) {
return;
}
matchingKeys.push(key);
});
}
// If the key being connected to does not exist we initialize the value with null. For subscribers that connected
// directly via connect() they will simply get a null value sent to them without any information about which key matched
// since there are none matched. In withOnyx() we wait for all connected keys to return a value before rendering the child
Expand Down
Loading