Proof that sourceValue has a race condition

[chuckdries]

Onyx sourceValue issues

These tests demonstrate multiple issues with Onyx sourceValue handling:

1. Race Condition: Multiple discrete updates batched → only last sourceValue visible to component
2. Stale keys: sourceValue preserves the keys of the latest onyx update during unrelated rerenders

See the thread in #quality for more info

Test Files

simpleSourceValueRaceConditionDemo.ts - Race condition test proving batching loses intermediate sourceValues
useSidebarOrderedReportsVulnerability.ts - Logic bug and compound issue tests replicating production patterns Deleted, since useSidebarOrderedReports was refactored away from that pattern
staleSourceValueTest - Test demonstrating that sourceValue persists during unrelated renders, leading to unnecessary cache busting

How to Run the Tests

# Run the race condition test
npm test -- tests/unit/simpleSourceValueRaceConditionDemo.ts

# Run the useSidebarOrderedReports display bug tests
npm test -- tests/unit/useSidebarOrderedReportsDisplayBug.ts

# Run the staleSourceValueTest tests
npm test -- tests/unit/staleSourceValueTest.ts

# Or run all 3 at once
npm test -- tests/unit/simpleSourceValueRaceConditionDemo.ts tests/unit/useSidebarOrderedReportsDisplayBug.ts tests/unit/staleSourceValueTest.ts

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[chuckdries]

I have read the CLA Document and I hereby sign the CLA