[HOLD] feat: add visibilitychange probe for proactive IDB health check by leshniak · Pull Request #788 · Expensify/react-native-onyx

leshniak · 2026-05-20T11:08:13Z

Details

HOLD until #780 will be merged

Adds a proactive visibilitychange probe to the IDB connection manager, building on the reactive heal mechanism from #780.

Problem: Safari kills IDB connections for backgrounded tabs (WebKit #197050, #201483). When the user returns to the Expensify tab, the app fires a ReconnectApp write storm that hits the dead cached dbp — every write fails before the reactive heal can kick in.

Solution: Register a visibilitychange listener inside createStore() that runs a lightweight readonly count() probe when the tab becomes visible. If the probe detects a dead IDB connection, it drops the stale dbp before the write storm arrives, so the first real operation opens a fresh connection.

What it does:

isStaleConnectionError() — union detector for all three stale connection error types (InvalidStateError, backing store corruption, connection lost)
visibilitychange listener with probePromise guard — prevents stale probe from clearing a dbp that was already replaced by a concurrent heal/retry
Classified req.onerror — only drops dbp for actual stale connection errors, not unrelated IDB errors
Diagnostic logging: logInfo on probe start ("tab became visible, checking connection health") and healthy result ("connection is healthy"); logAlert on stale detection ("stale connection detected, dropping cached connection") with error message
Guarded by typeof document !== 'undefined' for SSR/Node safety

Depends on: #780 (reactive heal mechanism)

Related Issues

Expensify/App#87864

Automated Tests

4 new tests in tests/unit/storage/providers/createStoreTest.ts:

Visibilitychange probe (4): probe detects dead connection + drops dbp, skipped when no dbp, healthy connection preserved, InvalidStateError sync throw handled

All 456 tests pass.

Manual Test Steps

Simulating Safari connection lost:

Open the app in Safari, log in
Switch to a different tab and wait 30+ seconds (Safari may kill IDB connections for backgrounded tabs)
Switch back to the Expensify tab
Verify in console: IDB visibilitychange probe: stale connection detected, dropping cached connection appears (if Safari killed the connection)
Interact with the app — it should recover seamlessly

Author Checklist

Screenshots/Videos

Android: Native

N/A — library-level change, IDB is web-only. No UI, no native code touched.

Android: mWeb Chrome

N/A — library-level change, IDB is web-only. No UI, no native code touched.

iOS: Native

N/A — library-level change, IDB is web-only. No UI, no native code touched.

iOS: mWeb Safari

N/A — library-level change, IDB is web-only. No UI, no native code touched.

MacOS: Chrome / Safari

Healed (simulated error):

healed.mov

Killed connection (simulated error):

killed.mp4

Exhausted (simulated error):

exhausted.mov

Healed (simulated on Safari):

safari_error.mp4

Killed connection (simulated on Safari):

safari_killed.mp4

Exhausted (simulated on Safari):

safari_exhausted.mp4

Healed offline (simulated on Chrome):

offline.mp4

Register a visibilitychange listener inside createStore() that runs a lightweight readonly probe when the tab returns to foreground. If the probe detects a dead IDB connection (connection lost, backing store error, or InvalidStateError), it drops the cached dbp so the next real operation opens a fresh connection instead of failing. This prevents the ReconnectApp write storm from hitting a dead IDB connection after Safari backgrounds a tab. Addresses Expensify/App#87864. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Probe start: logInfo when tab becomes visible and probe begins - Probe healthy: logInfo confirming connection is healthy - Probe stale: logAlert with error details when stale connection detected - Heal attempts/success/exhaustion/non-recoverable: same as Expensify#780 - Updated test assertions to match new log messages and levels Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The "connection is healthy" log was emitted synchronously after count(), before the IDB request completed. If the request later failed via onerror, both healthy and stale logs would fire for the same visibility event. Now only logs on actual success. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b63de8b399

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-27T08:04:57Z

-            throw error;
+            };
+
+            probePromise.then((db) => {


Handle probe promise rejections

When the tab becomes visible while dbp is still a pending indexedDB.open() and that open later rejects (for example with the same backing-store or connection-lost errors handled below), this separate probePromise.then(...) chain rejects without any rejection handler. The original store operation may catch its own chain, but the promise returned by this then is ignored, so browsers can emit an unhandled rejection during foregrounding; add a rejection handler/catch for the probe path.

Useful? React with 👍 / 👎.

@elirangoshen have you checked this comment? Is it still relevant?

fabioh8010 · 2026-05-27T08:16:11Z

hold for my review 🙏

fabioh8010 · 2026-05-28T08:32:35Z

@leshniak This PR seem to have many of the changes from #780, I think it's best to put this one on HOLD until that PR is merged, will facilitate review.

leshniak · 2026-05-28T14:20:37Z

@fabioh8010 agree - updated.

In some environments DOMException does not inherit from Error. Use (error instanceof Error || error instanceof DOMException) for all three detection functions to avoid missing IDB errors in those envs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…al' into fix/idb-visibilitychange-probe

Avoid silently mislabeling future error categories as connection lost. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…-internal/react-native-onyx into fix/idb-visibilitychange-probe

fabioh8010

@elirangoshen let's double check the test steps/screen recordings again, and please add for iOS: mWeb Safari too.
If you can't edit the PR body feel free to close this one and open another one by yourself as author

fabioh8010 · 2026-06-03T15:05:54Z

+    // Safari kills IDB connections for backgrounded tabs. By probing before
+    // the ReconnectApp write storm hits, we drop the stale dbp early so the
+    // first real operation opens a fresh connection instead of failing.
+    if (typeof document !== 'undefined') {


Why do we need to have this condition? As IDB is used in web platforms only this is supposed to be always defined, right?

fabioh8010 · 2026-06-03T15:06:11Z

+    // Proactive IDB health check when tab returns to foreground.
+    // Safari kills IDB connections for backgrounded tabs. By probing before
+    // the ReconnectApp write storm hits, we drop the stale dbp early so the
+    // first real operation opens a fresh connection instead of failing.


Remove mentions of ReconnectApp

- Remove the `typeof document !== 'undefined'` guard; IDBKeyValProvider runs on web only, where document is always defined. - Drop the App-specific "ReconnectApp" reference from the probe comment. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

elirangoshen · 2026-06-05T10:24:11Z

Closing in favor of a new PR opened by me as author (per @fabioh8010's suggestion, since I couldn't edit this PR's body). The new PR carries the full template checklist + the requested review changes.

#798

Its in draft now and i'm working to make it ready soon.

The visibilitychange probe adds a separate .then branch off the cached open promise. If the tab becomes visible while dbp is still a pending indexedDB.open() that later rejects, that branch rejected with no handler, surfacing an unhandled rejection on foregrounding. Add a .catch on the probe chain (cacheOpenPromise already clears dbp on its own branch). Addresses PR Expensify#788 review (chatgpt-codex-connector). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fabioh8010 · 2026-06-08T08:05:42Z

@arosiclair Could you close this PR? Explanation here.

melvin-bot Bot assigned leshniak May 20, 2026

leshniak mentioned this pull request May 20, 2026

[Onyx] Investigate UnknownError: Connection to Indexed Database server lost. storage error Expensify/App#87864

Open

fabioh8010 mentioned this pull request May 25, 2026

[Tracking] Onyx Improvements Expensify/App#80355

Open

leshniak and others added 3 commits May 26, 2026 14:29

leshniak force-pushed the fix/idb-visibilitychange-probe branch from bcd1f6e to b63de8b Compare May 26, 2026 13:07

leshniak marked this pull request as ready for review May 27, 2026 08:02

leshniak requested a review from a team as a code owner May 27, 2026 08:02

melvin-bot Bot requested review from arosiclair and removed request for a team May 27, 2026 08:03

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

leshniak mentioned this pull request May 27, 2026

[Onyx] Investigate UnknownError: Internal error opening backing store for indexedDB.open. storage error Expensify/App#87862

Closed

leshniak changed the title ~~feat: add visibilitychange probe for proactive IDB health check~~ [HOLD] feat: add visibilitychange probe for proactive IDB health check May 28, 2026

leshniak and others added 5 commits May 29, 2026 12:18

Merge remote-tracking branch 'origin/fix/idb-corruption-detect-and-he…

f492eac

…al' into fix/idb-visibilitychange-probe

fix: add fallback label in getBudgetedHealErrorLabel

00e8667

Avoid silently mislabeling future error categories as connection lost. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge branch 'main' into fix/idb-visibilitychange-probe

af905f9

Merge branch 'fix/idb-visibilitychange-probe' of github.com:callstack…

7ff3bac

…-internal/react-native-onyx into fix/idb-visibilitychange-probe

fabioh8010 suggested changes Jun 3, 2026

View reviewed changes

fabioh8010 mentioned this pull request Jun 3, 2026

[Onyx] Add IDB healing mechanism for "Internal error opening backing store" Expensify/App#90636

Open

arosiclair closed this Jun 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD] feat: add visibilitychange probe for proactive IDB health check#788

[HOLD] feat: add visibilitychange probe for proactive IDB health check#788
leshniak wants to merge 9 commits into
Expensify:mainfrom
callstack-internal:fix/idb-visibilitychange-probe

leshniak commented May 20, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Uh oh!

fabioh8010 Jun 3, 2026

Uh oh!

fabioh8010 commented May 27, 2026

Uh oh!

fabioh8010 commented May 28, 2026

Uh oh!

leshniak commented May 28, 2026

Uh oh!

fabioh8010 left a comment

Uh oh!

fabioh8010 Jun 3, 2026

Uh oh!

fabioh8010 Jun 3, 2026

Uh oh!

elirangoshen commented Jun 5, 2026 •

edited

Loading

Uh oh!

fabioh8010 commented Jun 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

leshniak commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

HOLD until #780 will be merged

Related Issues

Automated Tests

Manual Test Steps

Author Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 commented May 27, 2026

Uh oh!

fabioh8010 commented May 28, 2026

Uh oh!

leshniak commented May 28, 2026

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

elirangoshen commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabioh8010 commented Jun 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leshniak commented May 20, 2026 •

edited

Loading

elirangoshen commented Jun 5, 2026 •

edited

Loading