Fix some errors

Author: Explosion-Scratch

lib/installer.js

@@ -108,6 +108,13 @@ const performInstallation = async (args, isUpdate = false) => {
           capabilities,
           log,
         );
+
+        // Handle script installation case
+        if (result && result.method === "script") {
+          log.log(`Successfully installed via script: ${source.repo}`);
+          return;
+        }
+
         selected = result.selected;
         releaseInfo = result.releaseInfo;
         break;
@@ -152,8 +159,7 @@ const performInstallation = async (args, isUpdate = false) => {
     }
 
     log.log(
-      `Successfully ${
-        isUpdate ? "updated" : "installed"
+      `Successfully ${isUpdate ? "updated" : "installed"
       }: ${installationResult.binaries.join(", ")}`,
     );
   } finally {
@@ -238,8 +244,7 @@ const handleSmartUrlSource = async (
       log.debug("Assets found:");
       result.assets.forEach((asset, index) => {
         log.debug(
-          `  ${index + 1}. ${asset.name} (ext: ${
-            asset.extension || "none"
+          `  ${index + 1}. ${asset.name} (ext: ${asset.extension || "none"
           }, url: ${asset.browser_download_url})`,
         );
       });
@@ -253,15 +258,14 @@ const handleSmartUrlSource = async (
       log.log("No compatible assets found. Available downloads:");
       result.assets.forEach((asset, index) => {
         log.log(
-          `  ${index + 1}. ${asset.name} (${
-            asset.extension || "no extension"
+          `  ${index + 1}. ${asset.name} (${asset.extension || "no extension"
           }) - ${asset.browser_download_url}`,
         );
       });
 
       throw new Error(
         `Couldn't find a compatible download for ${platformInfo.platform}/${platformInfo.arch}. ` +
-          `Check manually: ${source.url}`,
+        `Check manually: ${source.url}`,
       );
     }
 
@@ -287,8 +291,7 @@ const handleWebsiteSource = async (source, platformInfo, capabilities, log) => {
     log.debug("Assets found:");
     assets.forEach((asset, index) => {
       log.debug(
-        `  ${index + 1}. ${asset.name} (ext: ${
-          asset.extension || "none"
+        `  ${index + 1}. ${asset.name} (ext: ${asset.extension || "none"
         }, url: ${asset.browser_download_url})`,
       );
     });
@@ -302,15 +305,14 @@ const handleWebsiteSource = async (source, platformInfo, capabilities, log) => {
     log.log("No compatible assets found. Available downloads:");
     assets.forEach((asset, index) => {
       log.log(
-        `  ${index + 1}. ${asset.name} (${
-          asset.extension || "no extension"
+        `  ${index + 1}. ${asset.name} (${asset.extension || "no extension"
         }) - ${asset.browser_download_url}`,
       );
     });
 
     throw new Error(
       `Couldn't find a compatible download for ${platformInfo.platform}/${platformInfo.arch}. ` +
-        `Check manually: ${source.url}`,
+      `Check manually: ${source.url}`,
     );
   }
 
@@ -326,10 +328,10 @@ const displayScriptPreview = (script, log) => {
   const { code, source, score } = script;
   log.log(
     `Found installer code in ${source} (score: ${score}):\n\n` +
-      colors.fg.green +
-      code +
-      colors.reset +
-      "\n",
+    colors.fg.green +
+    code +
+    colors.reset +
+    "\n",
   );
 };
 
@@ -455,6 +457,8 @@ const handleGitHubSource = async (source, platformInfo, capabilities, log) => {
     body,
   );
 
+  log.debug(`Found ${installScripts.length} install scripts`);
+
   // Check for installer.sh in assets
   const installerScript = assets.find((i) => i.name.includes("installer.sh"));
   if (installerScript) {
@@ -490,6 +494,8 @@ const handleGitHubSource = async (source, platformInfo, capabilities, log) => {
   const shouldUseInstallSnippets =
     !selected || hasHighPriorityInstallScript(installScripts);
 
+  log.debug(`Selected asset: ${!!selected}, use snippets: ${shouldUseInstallSnippets}, scripts: ${installScripts.length}`);
+
   if (shouldUseInstallSnippets && installScripts.length > 0) {
     if (!selected) {
       log.debug(`No suitable asset found, using install scripts as fallback`);
@@ -519,7 +525,7 @@ const handleGitHubSource = async (source, platformInfo, capabilities, log) => {
       );
       addInstallation(installRecord);
 
-      return;
+      return { success: true, method: "script" };
     }
   }
 
@@ -533,7 +539,7 @@ const handleGitHubSource = async (source, platformInfo, capabilities, log) => {
     }
     throw new Error(
       `Couldn't find a compatible binary for ${platformInfo.platform}/${platformInfo.arch}. ` +
-        `Check manually: https://github.com/${source.owner}/${source.repo}/releases`,
+      `Check manually: https://github.com/${source.owner}/${source.repo}/releases`,
     );
   }
 

lib/sources.js

@@ -533,26 +533,27 @@ const SCRIPT_DETECTION_CONFIG = {
   MIN_SCORE_THRESHOLD: 5,
   MAX_CODE_LINES: 10,
   REJECTION_KEYWORDS: [
-    "installing",
     "](#",
     "](http",
     "- [",
-    "ls",
-    "cd",
-    "pwd",
-    "echo",
-    "cat",
-    "grep",
     "brew update",
     "brew upgrade",
-    "sed",
     "copy and paste",
     "```",
-    "sudo rm",
-    "http://",
     "open powershell",
     "open terminal",
   ],
+  REJECTION_STARTSWITH: [
+    "sudo rm",
+    "http://",
+    "grep ",
+    "sed ",
+    "ls ",
+    "echo ",
+    "cat ",
+    "cd ",
+    "pwd",
+  ],
   SCORE_WEIGHTS: {
     HIGH: 10,
     MEDIUM: 5,
@@ -579,12 +580,17 @@ const isInstallScript = (code) => {
   if (!code || typeof code !== "string") return false;
 
   const lowerCode = code.toLowerCase().trim();
-  const { REJECTION_KEYWORDS, MAX_CODE_LINES, MIN_SCORE_THRESHOLD } =
-    SCRIPT_DETECTION_CONFIG;
-
-  // Reject obvious non-install scripts
+  const {
+    REJECTION_KEYWORDS,
+    REJECTION_STARTSWITH,
+    MAX_CODE_LINES,
+    MIN_SCORE_THRESHOLD,
+  } = SCRIPT_DETECTION_CONFIG;
+
+  // Reject obvious non-install scripts - only reject if script STARTS with these keywords
   if (
     REJECTION_KEYWORDS.some((keyword) => lowerCode.includes(keyword)) ||
+    REJECTION_STARTSWITH.some((keyword) => lowerCode.startsWith(keyword)) ||
     lowerCode.split("\n").length > MAX_CODE_LINES
   ) {
     return false;
@@ -657,21 +663,21 @@ const normalizeCode = (code) => code.replace(/\s+/g, " ").trim();
 
 const removeCommentLines = (code) => {
   if (!code || typeof code !== 'string') return code;
-  
+
   return code
     .split('\n')
     .filter(line => {
       const trimmedLine = line.trim();
-      
+
       // Preserve shebang lines
       if (trimmedLine.startsWith('#!')) {
         return true;
       }
-      
+
       // Remove lines that start with common comment patterns
       return !(
-        trimmedLine.startsWith('#') || 
-        trimmedLine.startsWith('//') || 
+        trimmedLine.startsWith('#') ||
+        trimmedLine.startsWith('//') ||
         trimmedLine.startsWith('/*') ||
         trimmedLine.startsWith('*') ||
         trimmedLine.startsWith('"""') ||