Add edit option for install scripts

- Added edit functionality to script selection menu
- Users can now press 'e' to edit install scripts in default editor
- Supports both single and multiple script scenarios
- Creates temporary file for editing and cleans up afterward
- Falls back to original script if editing fails

Author: Explosion-Scratch

lib/installer.js

@@ -39,6 +39,8 @@ const {
   checkPath,
   processInstallSnippetReplacements,
   promptChoice,
+  promptChoiceWithEdit,
+  editScriptInEditor,
   colors,
 } = require("./utils");
 
@@ -356,16 +358,42 @@ const displayScriptList = (installScripts, log) => {
 
   log.log(`  ${continueOption}. Continue to regular installation`);
   log.log(`  ${exitOption}. Exit installation`);
+  log.log(`  e. Edit selected script before running`);
 };
 
 const handleSingleScript = async (script, log) => {
   displayScriptPreview(script, log);
 
-  const shouldRun = await confirm(
-    "Run install script (y) or continue to regular installation (n)?",
-  );
+  while (true) {
+    const readline = require('readline');
+    const rli = readline.createInterface({
+      input: process.stdin,
+      output: process.stdout,
+    });
+
+    const choice = await new Promise((resolve) => {
+      rli.question(`${colors.fg.yellow}Run install script (y/n) or edit (e)?${colors.reset} `, (ans) => {
+        rli.close();
+        resolve(ans.trim().toLowerCase());
+      });
+    });
 
-  return shouldRun ? script : null;
+    if (choice === 'e') {
+      const editedScript = await editScriptInEditor(script);
+      displayScriptPreview(editedScript, log);
+      
+      const shouldRun = await confirm(
+        "Run this edited install script (y) or continue to regular installation (n)?",
+      );
+
+      if (shouldRun) return editedScript;
+      return null;
+    } else if (choice === 'y' || choice === 'yes') {
+      return script;
+    } else if (choice === 'n' || choice === 'no') {
+      return null;
+    }
+  }
 };
 
 const handleMultipleScripts = async (installScripts, log) => {
@@ -375,25 +403,53 @@ const handleMultipleScripts = async (installScripts, log) => {
   while (true) {
     displayScriptList(installScripts, log);
 
-    const choice = await promptChoice(
-      `Preview install script (1-${EXIT_OPTION}): `,
-      EXIT_OPTION,
-    );
+    const readline = require('readline');
+    const rli = readline.createInterface({
+      input: process.stdin,
+      output: process.stdout,
+    });
 
-    if (choice <= installScripts.length) {
-      const script = installScripts[choice - 1];
-      displayScriptPreview(script, log);
+    const choice = await new Promise((resolve) => {
+      rli.question(`${colors.fg.yellow}Preview install script (1-${EXIT_OPTION}) or 'e' to edit:${colors.reset} `, (ans) => {
+        rli.close();
+        resolve(ans.trim().toLowerCase());
+      });
+    });
 
+    if (choice === 'e') {
+      const scriptChoice = await promptChoice(
+        `Which script would you like to edit? (1-${installScripts.length}): `,
+        installScripts.length,
+      );
+      const scriptToEdit = installScripts[scriptChoice - 1];
+      const editedScript = await editScriptInEditor(scriptToEdit);
+      displayScriptPreview(editedScript, log);
+      
       const shouldRun = await confirm(
-        "Run this install script (y) or choose a different one (n)?",
+        "Run this edited install script (y) or choose a different one (n)?",
       );
 
-      if (shouldRun) return script;
+      if (shouldRun) return editedScript;
       // Continue loop if user chooses 'n'
-    } else if (choice === CONTINUE_OPTION) {
-      return null; // Continue to regular installation
-    } else if (choice === EXIT_OPTION) {
-      throw new Error("Installation aborted by user");
+    } else {
+      const numericChoice = parseInt(choice);
+      if (numericChoice <= installScripts.length) {
+        const script = installScripts[numericChoice - 1];
+        displayScriptPreview(script, log);
+
+        const shouldRun = await confirm(
+          "Run this install script (y) or choose a different one (n)?",
+        );
+
+        if (shouldRun) return script;
+        // Continue loop if user chooses 'n'
+      } else if (numericChoice === CONTINUE_OPTION) {
+        return null; // Continue to regular installation
+      } else if (numericChoice === EXIT_OPTION) {
+        throw new Error("Installation aborted by user");
+      } else {
+        console.log(`${colors.fg.red}Invalid choice. Please try again.${colors.reset}`);
+      }
     }
   }
 };

lib/utils.js

@@ -112,6 +112,91 @@ const promptChoice = (question, maxChoice) => {
   });
 };
 
+const promptChoiceWithEdit = (question, maxChoice, allowEdit = false) => {
+  if (maxChoice < 1) {
+    throw new Error("maxChoice must be at least 1");
+  }
+
+  return new Promise((resolve) => {
+    const askQuestion = () => {
+      const rli = readline.createInterface({
+        input: process.stdin,
+        output: process.stdout,
+      });
+
+      let editPrompt = "";
+      if (allowEdit) {
+        editPrompt = ` or 'e' to edit`;
+      }
+
+      rli.question(`${colors.fg.yellow}${question}${editPrompt}${colors.reset} `, (ans) => {
+        const trimmed = ans.trim().toLowerCase();
+        rli.close();
+
+        if (allowEdit && trimmed === 'e') {
+          resolve('edit');
+          return;
+        }
+
+        const choice = parseInt(trimmed);
+        if (isNaN(choice) || choice < 1 || choice > maxChoice) {
+          console.log(
+            `${colors.fg.red}Invalid choice. Please enter a number between 1 and ${maxChoice}${allowEdit ? " or 'e' to edit" : ""}.${colors.reset}`
+          );
+          // Use setTimeout to avoid stack overflow
+          setTimeout(askQuestion, 0);
+        } else {
+          resolve(choice);
+        }
+      });
+    };
+
+    askQuestion();
+  });
+};
+
+const editScriptInEditor = async (script) => {
+  const { execSync } = require('child_process');
+  const fs = require('fs');
+  const os = require('os');
+  const path = require('path');
+
+  // Create a temporary file with the script content
+  const tempDir = os.tmpdir();
+  const tempFile = path.join(tempDir, `justinstall-script-${Date.now()}.sh`);
+  
+  try {
+    fs.writeFileSync(tempFile, script.code);
+    
+    // Determine the default editor
+    const editor = process.env.EDITOR || process.env.VISUAL || 'nano';
+    
+    console.log(`${colors.fg.cyan}Opening editor: ${editor}${colors.reset}`);
+    
+    // Open the editor and wait for it to close
+    execSync(`${editor} "${tempFile}"`, { stdio: 'inherit' });
+    
+    // Read the modified content
+    const modifiedCode = fs.readFileSync(tempFile, 'utf8');
+    
+    // Return the updated script
+    return {
+      ...script,
+      code: modifiedCode
+    };
+  } catch (error) {
+    console.error(`${colors.fg.red}Error opening editor: ${error.message}${colors.reset}`);
+    return script; // Return original script if editing fails
+  } finally {
+    // Clean up the temporary file
+    try {
+      fs.unlinkSync(tempFile);
+    } catch (e) {
+      // Ignore cleanup errors
+    }
+  }
+};
+
 const fileSize = (bytes, si = false, dp = 1) => {
   const thresh = si ? 1000 : 1024;
 
@@ -233,6 +318,8 @@ module.exports = {
   createLogger,
   confirm,
   promptChoice,
+  promptChoiceWithEdit,
+  editScriptInEditor,
   fileSize,
   createLink,
   checkPath,