Merge pull request #466 from Extra-Chill/fix-workspace-git-status-loop

Prevent repeated workspace git status loops

Author: chubes4

inc/Tools/WorkspaceTools.php

@@ -1143,7 +1143,7 @@ public function getDeleteDefinition(): array
      */
     public function getGitStatusDefinition(): array
     {
-        return $this->simpleGitDefinition('handleGitStatus', 'Get git status information for a workspace handle.', array(), array( 'name' ), array( 'duplicate_policy' => 'repeatable' ));
+        return $this->simpleGitDefinition('handleGitStatus', 'Get git status information for a workspace handle. Use once to inspect cleanliness, then move to a concrete edit, commit, or completion outcome.', array());
     }
 
     /**

tests/smoke-workspace-policy-tools.php

@@ -97,6 +97,9 @@ static function ( array $tools ) use ( $tool_id, $definition_callback, $contexts
     $show_definition = $workspace_tools->getShowDefinition();
     $assert('workspace_show does not allow duplicate repeat calls', 'repeatable' !== ( $show_definition['runtime']['duplicate_policy'] ?? null ));
 
+    $git_status_definition = $workspace_tools->getGitStatusDefinition();
+    $assert('workspace_git_status does not allow duplicate repeat calls', 'repeatable' !== ( $git_status_definition['runtime']['duplicate_policy'] ?? null ));
+
     $ls_definition = $workspace_tools->getLsDefinition();
     $assert('workspace_ls still allows intentional repeat calls', 'repeatable' === ( $ls_definition['runtime']['duplicate_policy'] ?? null ));