Merge pull request #460 from Extra-Chill/fix-workspace-show-duplicate-loop

Prevent repeated workspace show loops

Author: chubes4

inc/Tools/WorkspaceTools.php

@@ -908,8 +908,7 @@ public function getListDefinition(): array
      */
     public function getShowDefinition(): array
     {
-        return $this->repeatableDefinition(
-            array(
+        return array(
             'class'       => __CLASS__,
             'method'      => 'handleShow',
             'description' => 'Show detailed information about a workspace repository (branch, remote, latest commit, dirty count).',
@@ -923,7 +922,6 @@ public function getShowDefinition(): array
             ),
             'required'   => array( 'name' ),
             ),
-            ) 
         );
     }
 

tests/smoke-workspace-policy-tools.php

@@ -77,7 +77,7 @@ static function ( array $tools ) use ( $tool_id, $definition_callback, $contexts
 
     echo "Workspace policy tools - smoke\n";
 
-    new \DataMachineCode\Tools\WorkspaceTools();
+    $workspace_tools = new \DataMachineCode\Tools\WorkspaceTools();
     $tools = apply_filters('datamachine_tools', array());
 
     $default_pipeline_tools = array(
@@ -94,6 +94,12 @@ static function ( array $tools ) use ( $tool_id, $definition_callback, $contexts
         $assert("{$tool} remains default pipeline-visible", array( 'chat', 'pipeline' ) === ( $tools[ $tool ]['modes'] ?? null ));
     }
 
+    $show_definition = $workspace_tools->getShowDefinition();
+    $assert('workspace_show does not allow duplicate repeat calls', 'repeatable' !== ( $show_definition['runtime']['duplicate_policy'] ?? null ));
+
+    $ls_definition = $workspace_tools->getLsDefinition();
+    $assert('workspace_ls still allows intentional repeat calls', 'repeatable' === ( $ls_definition['runtime']['duplicate_policy'] ?? null ));
+
     $policy_tools = array(
     'workspace_write',
     'workspace_edit',