Fix mounted runtime bootstrap lint

homeboy-ci[bot] · homeboy-ci[bot] · commit be8a20e53055 · 2026-06-15T11:27:11.000-04:00
diff --git a/inc/Runtime/MountedSandboxBootstrap.php b/inc/Runtime/MountedSandboxBootstrap.php
@@ -111,14 +111,14 @@ public static function adopt_workspace_mounts(): void {
 			return;
 		}
 
-		$workspace_root = rtrim((string) DATAMACHINE_WORKSPACE_PATH, '/');
+		$workspace_root = rtrim( (string) DATAMACHINE_WORKSPACE_PATH, '/');
 		$mounts         = self::workspace_mounts(self::$context, $workspace_root);
 		foreach ( $mounts as $mount ) {
 			if ( ! empty($mount['repo_backed']) ) {
 				continue;
 			}
 
-			$path = (string) ( $mount['path'] ?? '' );
+			$path = (string) $mount['path'];
 			if ( '' === $path || ! is_dir($path) || ! is_dir($path . '/.git') ) {
 				continue;
 			}
@@ -155,7 +155,7 @@ private static function workspace_mounts( array $context, string $workspace_root
 				if ( ! is_array($mount) ) {
 					continue;
 				}
-				$target = rtrim((string) ( $mount['target'] ?? '' ), '/');
+				$target = rtrim( (string) ( $mount['target'] ?? '' ), '/');
 				if ( '' === $target || 0 !== strpos($target . '/', $workspace_root . '/') ) {
 					continue;
 				}
@@ -170,7 +170,8 @@ private static function workspace_mounts( array $context, string $workspace_root
 			return $mounts;
 		}
 
-		foreach ( glob($workspace_root . '/*', GLOB_ONLYDIR) ?: array() as $path ) {
+		$paths = glob($workspace_root . '/*', GLOB_ONLYDIR);
+		foreach ( false !== $paths ? $paths : array() as $path ) {
 			$mounts[] = array(
 				'path'        => $path,
 				'repo_backed' => is_file($path . '/.git'),

Original file line number	Diff line number	Diff line change
`@@ -111,14 +111,14 @@ public static function adopt_workspace_mounts(): void {`
`111`	`111`	`return;`
`112`	`112`	`}`
`113`	`113`
`114`		`- $workspace_root = rtrim((string) DATAMACHINE_WORKSPACE_PATH, '/');`
	`114`	`+ $workspace_root = rtrim( (string) DATAMACHINE_WORKSPACE_PATH, '/');`
`115`	`115`	`$mounts = self::workspace_mounts(self::$context, $workspace_root);`
`116`	`116`	`foreach ( $mounts as $mount ) {`
`117`	`117`	`if ( ! empty($mount['repo_backed']) ) {`
`118`	`118`	`continue;`
`119`	`119`	`}`
`120`	`120`
`121`		`- $path = (string) ( $mount['path'] ?? '' );`
	`121`	`+ $path = (string) $mount['path'];`
`122`	`122`	`if ( '' === $path \|\| ! is_dir($path) \|\| ! is_dir($path . '/.git') ) {`
`123`	`123`	`continue;`
`124`	`124`	`}`
`@@ -155,7 +155,7 @@ private static function workspace_mounts( array $context, string $workspace_root`
`155`	`155`	`if ( ! is_array($mount) ) {`
`156`	`156`	`continue;`
`157`	`157`	`}`
`158`		`- $target = rtrim((string) ( $mount['target'] ?? '' ), '/');`
	`158`	`+ $target = rtrim( (string) ( $mount['target'] ?? '' ), '/');`
`159`	`159`	`if ( '' === $target \|\| 0 !== strpos($target . '/', $workspace_root . '/') ) {`
`160`	`160`	`continue;`
`161`	`161`	`}`
`@@ -170,7 +170,8 @@ private static function workspace_mounts( array $context, string $workspace_root`
`170`	`170`	`return $mounts;`
`171`	`171`	`}`
`172`	`172`
`173`		`- foreach ( glob($workspace_root . '/*', GLOB_ONLYDIR) ?: array() as $path ) {`
	`173`	`+ $paths = glob($workspace_root . '/*', GLOB_ONLYDIR);`
	`174`	`+ foreach ( false !== $paths ? $paths : array() as $path ) {`
`174`	`175`	`$mounts[] = array(`
`175`	`176`	`'path' => $path,`
`176`	`177`	`'repo_backed' => is_file($path . '/.git'),`