Merge pull request #588 from Extra-Chill/fix/active-probe-cache-reference

Persist active worktree probe cache state

Author: chubes4

inc/Workspace/Workspace.php

@@ -2780,16 +2780,30 @@ private function build_active_no_signal_evidence_row( array $row, array &$github
 		}
 
 		$remote_ref             = 'refs/remotes/origin/' . $branch;
-		$remote                 = $this->time_worktree_probe($out['probe_timings_ms'], 'remote_tracking', fn() => $this->cached_active_no_signal_remote_tracking_probe($primary_path, $remote_ref, $probe_cache));
+		$remote                 = $this->time_worktree_probe(
+			$out['probe_timings_ms'],
+			'remote_tracking',
+			function () use ( $primary_path, $remote_ref, &$probe_cache ) {
+				return $this->cached_active_no_signal_remote_tracking_probe($primary_path, $remote_ref, $probe_cache);
+			}
+		);
 		$out['remote_tracking'] = ! is_wp_error($remote) && ! $this->is_git_timeout_error($remote);
 
-		$default_ref = $this->time_worktree_probe($out['probe_timings_ms'], 'default_ref', fn() => $this->cached_active_no_signal_default_ref_probe($primary_path, $probe_cache));
+		$default_ref = $this->time_worktree_probe(
+			$out['probe_timings_ms'],
+			'default_ref',
+			function () use ( $primary_path, &$probe_cache ) {
+				return $this->cached_active_no_signal_default_ref_probe($primary_path, $probe_cache);
+			}
+		);
 		if ( is_string($default_ref) && '' !== $default_ref ) {
 			$out['default_ref'] = $default_ref;
 			$outside            = $this->time_worktree_probe(
 				$out['probe_timings_ms'],
 				'commits_outside_default',
-				fn() => $this->cached_active_no_signal_commits_outside_default_probe($primary_path, $default_ref, $branch, $probe_cache)
+				function () use ( $primary_path, $default_ref, $branch, &$probe_cache ) {
+					return $this->cached_active_no_signal_commits_outside_default_probe($primary_path, $default_ref, $branch, $probe_cache);
+				}
 			);
 			if ( ! is_wp_error($outside) && ! $this->is_git_timeout_error($outside) ) {
 				$out['commits_outside_default'] = (int) trim( (string) ( $outside['output'] ?? '' ));
@@ -2805,7 +2819,13 @@ private function build_active_no_signal_evidence_row( array $row, array &$github
 		if ( (int) ( $out['dirty'] ?? 0 ) > 0 || (int) ( $out['unpushed'] ?? 0 ) > 0 ) {
 			$out['pr_lookup_skipped'] = 'dirty_or_unpushed_rows_are_always_manual_review';
 		} else {
-			$slug = $this->time_worktree_probe($out['probe_timings_ms'], 'github_slug', fn() => $this->cached_active_no_signal_github_slug_probe($primary_path, $probe_cache));
+			$slug = $this->time_worktree_probe(
+				$out['probe_timings_ms'],
+				'github_slug',
+				function () use ( $primary_path, &$probe_cache ) {
+					return $this->cached_active_no_signal_github_slug_probe($primary_path, $probe_cache);
+				}
+			);
 			if ( null !== $slug ) {
 				$pr = $this->time_worktree_probe($out['probe_timings_ms'], 'github_pr_lookup', fn() => $this->find_pr_for_branch_direct($slug, $branch, $github_cache, false));
 				if ( is_wp_error($pr) ) {

tests/smoke-worktree-metadata-reconcile.php

@@ -552,7 +552,7 @@ function () use ( $tmp ) {
     $assert(true, ! is_wp_error($active_report) && ( $active_report['success'] ?? false ), 'active/no-signal report succeeds');
     $assert(true, (bool) ( $active_report['review_only'] ?? false ), 'active/no-signal report is review-only');
     $assert(true, (int) ( $active_report['summary']['inspected'] ?? 0 ) > 0, 'active/no-signal report inspects rows');
-    $assert(true, isset($active_report['evidence']['probe_cache']['default_ref']['misses']), 'active/no-signal report exposes probe cache stats');
+    $assert(true, (int) ( $active_report['evidence']['probe_cache']['default_ref']['misses'] ?? 0 ) > 0, 'active/no-signal report records default ref cache misses');
     $active_rows = array();
     foreach ( (array) ( $active_report['rows'] ?? array() ) as $row ) {
         $active_rows[ $row['handle'] ?? '' ] = $row;