Drop vestigial test_backend setting#611
Merged
Merged
Conversation
data-machine-code set test_backend=host-smoke, but its smoke scripts use the smoke-*.php prefix convention, not the *-smoke.php suffix the WordPress test dispatcher discovers. The host-smoke backend's `find -name '*-smoke.php'` therefore matched zero files — the setting was a no-op. With the test_backend toggle removed upstream (tests route by file type through WP Codebox), drop the dead setting for hygiene.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-machine-codesettest_backend=host-smoke, but its smoke scripts use thesmoke-*.phpprefix convention (97 files), not the*-smoke.phpsuffix the WordPress test dispatcher discovers. The host-smoke backend'sfind -name '*-smoke.php'matched zero files — the setting was a no-op.With the
test_backendtoggle removed upstream (homeboy-extensions #1205: tests route by file type through WP Codebox), this drops the dead setting for hygiene.Note
DMC's 97
smoke-*.phpscripts don't run throughhomeboy testat all (naming mismatch with the dispatcher's*-smoke.phpcontract). Wiring them into the pipeline is a separate follow-up, out of scope here.AI assistance