Skip to content

Fix workspace worktree repo resolution#639

Merged
chubes4 merged 2 commits into
mainfrom
fix/issue-637-638-worktree-resolution
Jun 12, 2026
Merged

Fix workspace worktree repo resolution#639
chubes4 merged 2 commits into
mainfrom
fix/issue-637-638-worktree-resolution

Conversation

@chubes4

@chubes4 chubes4 commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Fixes remote-to-local fallback so workspace show homeboy and workspace worktree add homeboy ... can reuse an existing local primary when remote workspace state is present but missing that repo.
  • Normalizes workspace worktree add URL/path repo arguments to a matching local primary, and rejects unsupported URL/path arguments instead of creating malformed github://https://... or github:///Users/... handles.
  • Bounds cleanup git worktree remove calls and removes the unbounded rm -rf fallback so cleanup apply rows fail clearly instead of wedging on a single worktree.
  • Adds focused smokes for listed-primary fallback, remote URL/path rejection, local URL/path normalization, and cleanup removal guardrails.

Fixes #637.
Fixes #638.

Tests

  • php -l inc/Workspace/WorkspaceWorktreeCleanupEngine.php
  • php -l tests/smoke-worktree-cleanup-remove-guard.php
  • php tests/smoke-workspace-local-fallback.php
  • php tests/smoke-worktree-cleanup-remove-guard.php
  • php tests/smoke-worktree-cleanup.php (fails: existing duplicate skip-row count drift in dirty/artifact/external summary assertions; removal execution and primary/outside safety assertions pass)

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Drafted the workspace resolution fix, cleanup removal guard, regression smokes, and local verification commands; Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — failed

ℹ️ Auto-fix: homeboy lint data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since 4057301 --fix (or homeboy refactor data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since 4057301 --from lint --write)
ℹ️ Some issues may require manual fixes
ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 4057301

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27389315384

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Save test baseline: homeboy test data-machine-code --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 4057301

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27389315384

Audit

audit — passed

  • audit — 42 finding(s)
  • Total: 42 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 4057301

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27389315384
Tooling versions
  • Homeboy CLI: homeboy 0.228.13+a1b20bf
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 33a9fc73
  • Action: unknown@unknown

@chubes4 chubes4 merged commit b8a4183 into main Jun 12, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workspace worktree add URL/path inputs create malformed github handles workspace worktree add rejects registered primary handles

1 participant