Skip to content

Fix cleanup drain JSON run visibility#690

Merged
chubes4 merged 1 commit into
mainfrom
fix/issue-689-drain-json
Jun 13, 2026
Merged

Fix cleanup drain JSON run visibility#690
chubes4 merged 1 commit into
mainfrom
fix/issue-689-drain-json

Conversation

@chubes4

@chubes4 chubes4 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Emits the scheduled cleanup run JSON before --drain invokes Data Machine jobs so operators immediately get the run_id, job_id, and status/drain commands.
  • Keeps the existing high-level workspace cleanup run --drain path and still emits the final verified drain/status JSON after draining completes.
  • Extends the focused cleanup CLI smoke to prove the scheduled JSON exists before the parent drain command runs.

Fixes #689.

Verification

  • php tests/smoke-worktree-cleanup-cli.php
  • php tests/smoke-workspace-cleanup-run-context.php
  • php tests/smoke-cleanup-run-storage.php
  • php -l inc/Cli/Commands/WorkspaceCommand.php && php -l tests/smoke-worktree-cleanup-cli.php
  • git diff --check
  • composer validate --strict (reports existing package metadata warning: committed version field)

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Investigating the cleanup drain CLI path, drafting the minimal code/test change, and running local verification. Chris remains responsible for review and acceptance.

@chubes4 chubes4 merged commit bcd8aa3 into main Jun 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workspace cleanup --drain hangs without output

1 participant