Skip to content

Fix cleanup idle wrapper convergence#692

Merged
chubes4 merged 1 commit into
mainfrom
fix/issue-691-cleanup-empty-wrapper-convergence
Jun 13, 2026
Merged

Fix cleanup idle wrapper convergence#692
chubes4 merged 1 commit into
mainfrom
fix/issue-691-cleanup-empty-wrapper-convergence

Conversation

@chubes4

@chubes4 chubes4 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Treat empty pipeline_system_task wrapper descendants as terminal idle wrappers in cleanup status aggregation.
  • Prevent cleanup runs from staying waiting_on_children forever when drain reports no runnable work remains.
  • Add smoke coverage for the issue Cleanup status stays waiting on empty processing wrapper jobs #691 shape: processing parent, empty processing wrapper child, zero cleanup rows.

Fixes #691.

Verification

  • php tests/smoke-worktree-cleanup-cli.php
  • php -l inc/Cleanup/DataMachineJobCleanupRunEvidenceStore.php
  • php -l tests/smoke-worktree-cleanup-cli.php
  • git diff --check

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosed the cleanup convergence failure, drafted the fix and smoke coverage, and ran local verification. Chris remains responsible for review and testing.

@homeboy-ci

homeboy-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Audit

audit — passed

  • audit — 10 finding(s)
  • Total: 10 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 92c0dfa

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27472439592
Tooling versions
  • Homeboy CLI: homeboy 0.229.0+0f21fd5
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 838830a8
  • Action: unknown@unknown

@chubes4 chubes4 merged commit c6e766e into main Jun 13, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup status stays waiting on empty processing wrapper jobs

1 participant