Skip to content

Make cleanup worktree removal timeout resumable#702

Merged
chubes4 merged 2 commits into
mainfrom
fix/issue-699-worktree-remove-timeout
Jun 14, 2026
Merged

Make cleanup worktree removal timeout resumable#702
chubes4 merged 2 commits into
mainfrom
fix/issue-699-worktree-remove-timeout

Conversation

@chubes4

@chubes4 chubes4 commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a cleanup-specific git worktree remove timeout with a larger default than cheap git probes.
  • Threads remove_timeout through bounded cleanup apply, cleanup chunks, CLI, and ability input.
  • Classifies removal timeouts as remove_timeout and emits a --remove-timeout continuation command so cleanup can be resumed without weakening safety gates.

Closes #699.

Verification

  • php tests/smoke-worktree-cleanup-remove-guard.php
  • php tests/smoke-worktree-bounded-cleanup-eligible-apply.php
  • php tests/smoke-worktree-cleanup-cli.php
  • php tests/smoke-worktree-cleanup.php
  • php -l inc/Workspace/Workspace.php && php -l inc/Workspace/WorkspaceWorktreeCleanupEngine.php && php -l inc/Cli/Commands/WorkspaceCommand.php && php -l inc/Abilities/WorkspaceAbilities.php && php -l inc/Tasks/WorktreeCleanupChunkTask.php && php -l tests/smoke-worktree-bounded-cleanup-eligible-apply.php && php -l tests/smoke-worktree-cleanup-cli.php && php -l tests/smoke-worktree-cleanup-remove-guard.php
  • Safe installed CLI smoke: studio wp datamachine-code workspace worktree bounded-cleanup-eligible-apply --dry-run --limit=1 --format=json

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Investigated the cleanup timeout path, drafted the implementation and smoke coverage, and ran targeted verification. Chris remains responsible for review and merge.

@homeboy-ci

homeboy-ci Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since eb84901

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27498435975

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Save test baseline: homeboy test data-machine-code --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since eb84901

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27498435975

Audit

audit — passed

  • audit — 50 finding(s)
  • Total: 50 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since eb84901

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27498435975
Tooling versions
  • Homeboy CLI: homeboy 0.229.6+19ce162
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: adfd73d9
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 1782440 into main Jun 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make worktree remove timeout configurable or resumable during cleanup

1 participant