Skip to content

Fix cleanup classification for upstream-equivalent worktrees#863

Merged
chubes4 merged 1 commit into
mainfrom
fix/upstream-equivalent-cleanup-signals
Jul 4, 2026
Merged

Fix cleanup classification for upstream-equivalent worktrees#863
chubes4 merged 1 commit into
mainfrom
fix/upstream-equivalent-cleanup-signals

Conversation

@chubes4

@chubes4 chubes4 commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • classify upstream-equivalent active/no-signal rows before the dirty/unpushed fallback
  • preserve the dirty/unpushed protection for rows without positive equivalence evidence

Verification

  • php -l inc/Workspace/WorkspaceActiveNoSignalCleanup.php
  • reflected suggest_active_no_signal_action() locally to verify equivalent dirty rows classify as cleanup reconciliation candidates while non-equivalent dirty rows remain protected

AI assistance

  • AI assistance: Yes
  • Tool(s): GPT-5.5 via OpenCode
  • Used for: Diagnosed the cleanup classifier ordering bug, drafted the minimal code change, and ran local verification.

@homeboy-ci

homeboy-ci Bot commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

✅ lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine-code --changed-since a9bbea2

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/28706972500

Test

✅ test — passed

ℹ️ No impacted tests found for --changed-since a9bbea2
ℹ️ Run full suite if needed: homeboy test data-machine-code
Deep dive: homeboy test data-machine-code --changed-since a9bbea2

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/28706972500

Audit

✅ audit — passed

  • audit — 2 finding(s)
  • Total: 2 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since a9bbea2

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/28706972500
Tooling versions
  • Homeboy CLI: homeboy 0.280.13+89fee93c89fb+3ab628a
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 2da72e04
  • Action: unknown@unknown

@chubes4
chubes4 merged commit b7d5d32 into main Jul 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chubes4