Skip to content

chore: whole-tree phpcs debt blocks release preflight (skipped for v0.159.6) #2843

Description

@chubes4

Context

The homeboy release preflight lints the whole tree, while PR-scoped CI only lints changed files. As a result, v0.159.6 (PR #2842, a green, correct bugfix) was blocked at the release gate by pre-existing phpcs debt in files the PR never touched, and had to ship via --skip-checks --apply.

This issue tracks paying down that debt so releases stop needing --skip-checks.

Findings (from homeboy lint data-machine)

  • PHPCS SUMMARY: 65 errors, 24 warnings across 10 of 583 files. 37 auto-fixable.
  • Worst offenders:
    • inc/Core/Database/ProcessedItems/ProcessedItems.php — 34 errors (mostly WordPress.DB.PreparedSQL — interpolated table names / $wpdb->prepare() placeholder warnings on lines 89, 509, 514, 546, 716, 780, 811–828).
    • inc/Core/Database/Pipelines/Pipelines.php — 13 errors (5 lines).

Notes

  • Most PreparedSQL findings are interpolated table names (a known false-positive class that needs // phpcs:ignore with justification, not blind autofix — the values are code-defined constants, not request input).
  • Run phpcbf for the 37 auto-fixable items first, then hand-review the prepare() ones.
  • None of this was introduced by fix: attach default agent owner to system-triggered media/SEO task enqueues #2842; it's latent debt surfaced by the release gate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions