You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The homeboy release preflight lints the whole tree, while PR-scoped CI only lints changed files. As a result, v0.159.6 (PR #2842, a green, correct bugfix) was blocked at the release gate by pre-existing phpcs debt in files the PR never touched, and had to ship via --skip-checks --apply.
This issue tracks paying down that debt so releases stop needing --skip-checks.
Findings (from homeboy lint data-machine)
PHPCS SUMMARY: 65 errors, 24 warnings across 10 of 583 files. 37 auto-fixable.
Most PreparedSQL findings are interpolated table names (a known false-positive class that needs // phpcs:ignore with justification, not blind autofix — the values are code-defined constants, not request input).
Run phpcbf for the 37 auto-fixable items first, then hand-review the prepare() ones.
Context
The
homeboy releasepreflight lints the whole tree, while PR-scoped CI only lints changed files. As a result, v0.159.6 (PR #2842, a green, correct bugfix) was blocked at the release gate by pre-existing phpcs debt in files the PR never touched, and had to ship via--skip-checks --apply.This issue tracks paying down that debt so releases stop needing
--skip-checks.Findings (from
homeboy lint data-machine)inc/Core/Database/ProcessedItems/ProcessedItems.php— 34 errors (mostlyWordPress.DB.PreparedSQL— interpolated table names /$wpdb->prepare()placeholder warnings on lines 89, 509, 514, 546, 716, 780, 811–828).inc/Core/Database/Pipelines/Pipelines.php— 13 errors (5 lines).Notes
PreparedSQLfindings are interpolated table names (a known false-positive class that needs// phpcs:ignorewith justification, not blind autofix — the values are code-defined constants, not request input).phpcbffor the 37 auto-fixable items first, then hand-review theprepare()ones.