Skip to content

Honor allow policy for opt-in tools#2321

Merged
chubes4 merged 1 commit into
mainfrom
fix/opt-in-tools-allow-policy
May 28, 2026
Merged

Honor allow policy for opt-in tools#2321
chubes4 merged 1 commit into
mainfrom
fix/opt-in-tools-allow-policy

Conversation

@chubes4

@chubes4 chubes4 commented May 27, 2026

Copy link
Copy Markdown
Member

Summary

  • Carry explicit allow-mode agent tool policy into the early opt-in allow list before Data Machine gathers tool sources.
  • Allow request-level allow-mode tool_policy to expose requires_opt_in tools consistently with allow_only.
  • Add smoke coverage for opt-in tools allowed by tool policy.

Tests

  • php tests/tool-source-registry-smoke.php
  • php tests/agent-conversation-runner-request-smoke.php
  • vendor/bin/phpcs inc/Engine/AI/Tools/ToolPolicyResolver.php inc/Engine/AI/conversation-loop.php tests/tool-source-registry-smoke.php tests/agent-conversation-runner-request-smoke.php

Supports the WP Codebox sandbox workspace-write path after Extra-Chill/data-machine-code#459 and Automattic/wp-codebox#182.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Traced the WP Codebox sandbox tool policy issue, drafted the resolver fix and smoke coverage, and verified locally plus on Homeboy Lab.

@homeboy-ci

homeboy-ci Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since 7bb63b0

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26544775552

Test

test — passed

  • 72 passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since 7bb63b0

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26544775552

Audit

audit — passed

  • dead_code — 194 finding(s)
  • requested_detectors — 132 finding(s)
  • intra-method-duplication — 70 finding(s)
  • repeated_literal_shape — 13 finding(s)
  • field_patterns — 9 finding(s)
  • parallel-implementation — 8 finding(s)
  • structural — 8 finding(s)
  • dead_guard — 6 finding(s)
  • Taxonomy — 5 finding(s)
  • Abilities — 4 finding(s)
  • Total: 464 finding(s)

Deep dive: homeboy audit data-machine --changed-since 7bb63b0

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26544775552
Tooling versions
  • Homeboy CLI: homeboy 0.199.4+bc169bb1
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: fbe2bfe7
  • Action: unknown@unknown

@chubes4
chubes4 merged commit 4a244c0 into main May 28, 2026
5 checks passed
@chubes4
chubes4 deleted the fix/opt-in-tools-allow-policy branch May 28, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant