fix: bound public concert queries#226
Merged
Merged
Conversation
Member
Author
|
Review blocker addressed in both layers. This PR now asserts newest-first attendee ordering and the documented attendee object shape. Companion transport PR: Extra-Chill/extrachill-api#119. Merge order: Users #226 first, then API #119. Focused PHPUnit remains blocked before test loading by Extra-Chill/homeboy-extensions#2305; scoped PHPCS, syntax, and diff checks pass. |
…queries # Conflicts: # inc/concert-tracking/service.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1..100history and attendee bounds in the canonical Users service while preserving shipped defaults (20history,10attendees)created_atorderingCompanion transport PR
Extra-Chill/extrachill-api#119 mirrors these contracts in the shipped
/extrachill/v1routes and removes coerciveabsintsanitization. Merge this canonical Users PR first, then merge API #119.Verification
git diff --check origin/main...HEADpassedc27a8034-8fa6-47b7-ac3f-f02bc49812b8); two pre-existing alignment warnings remain outside changed hunks7700c630-0970-47cd-8aa6-ae1f08f318dd)Closes #219