Fail Core lint when analyzers fail#509
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer installhint.phpcs.xml.distwhile retaining.phpcs.xml.distfallback, and add smoke coverage for success, analyzer failure, and missing PHPStan.Motivation
This came out of reviewing why Homeboy did not flag a WordPress Core backport issue on WordPress/wordpress-develop#11766.
Weston Ruter noted a strict PHPStan
foreach.nonIterableissue insrc/wp-admin/site-editor.php: WordPress/wordpress-develop#11766 (comment)Strict PHPStan did catch the issue when run directly, but Homeboy still reported success because the core-dev lint runner swallowed analyzer exits with
|| true. The runner also skipped PHPCS in Core because it looked for.phpcs.xml.distwhile Core usesphpcs.xml.dist, and it treated missing Composer-installed analyzer binaries as warnings instead of actionable infrastructure failures.Testing
bash wordpress/scripts/test/core-dev-shape-smoke.shbash -n wordpress/scripts/lint/lint-runner-core-dev.sh && bash -n wordpress/scripts/test/core-dev-shape-smoke.shAI assistance