Improve naming, replace constantly updating params with on-demand updates

Author: lorow

ETVRTrackingModule.cs

@@ -34,7 +34,6 @@ public override void Teardown()
 
         public override void Update()
         {
-            _expressionMapper?.UpdateVRCFTEyeData();
             Thread.Sleep(10);
         }
     }

ExpressionStrategies/IExpressionMapper.cs

@@ -2,7 +2,7 @@
 
 namespace ETVRTrackingModule.ExpressionStrategies;
 
-public interface IExpressionMapper
+public interface ImappingStategy
 {
     public static string GetParamToMap(string oscAddress)
     {

ExpressionStrategies/V1Mapper.cs

@@ -5,7 +5,7 @@
 
 namespace ETVRTrackingModule.ExpressionStrategies;
 
-public class V1Mapper : IExpressionMapper
+public class V1Mapper : ImappingStategy
 {
     private Dictionary<string, float> _parameterValues = new()
     {
@@ -25,7 +25,7 @@ public V1Mapper(ILogger logger)
 
     public void handleOSCMessage(OSCMessage message)
     {
-        var paramToMap = IExpressionMapper.GetParamToMap(message.address);
+        var paramToMap = ImappingStategy.GetParamToMap(message.address);
         if (_parameterValues.ContainsKey(paramToMap))
         {
             _parameterValues[paramToMap] = message.value;

ExpressionStrategies/V2Mapper.cs

@@ -3,7 +3,7 @@
 
 namespace ETVRTrackingModule.ExpressionStrategies;
 
-public class V2Mapper : IExpressionMapper
+public class V2Mapper : ImappingStategy
 {
     private Dictionary<string, float> parameterValues = new()
     {
@@ -25,7 +25,7 @@ public V2Mapper(ILogger logger)
     }
     public void handleOSCMessage(OSCMessage message)
     {
-        string paramToMap = IExpressionMapper.GetParamToMap(message.address);
+        string paramToMap = ImappingStategy.GetParamToMap(message.address);
         if (parameterValues.ContainsKey(paramToMap))
         {
             parameterValues[paramToMap] = message.value;

ExpressionsMapper.cs

@@ -6,7 +6,7 @@ namespace ETVRTrackingModule
 {
     public class ExpressionsMapper
     {
-        private IExpressionMapper _mappingStrategy;
+        private ImappingStategy _mappingStrategy;
 
         ILogger _logger;
         public ExpressionsMapper(ILogger logger) 
@@ -20,14 +20,15 @@ public void MapMessage(OSCMessage msg)
             if (!msg.success)
                 return;
 
-            var nextStrategy =  IsV2Param(msg) ? (IExpressionMapper) new V2Mapper(_logger) : new V1Mapper(_logger);
+            var nextStrategy =  IsV2Param(msg) ? (ImappingStategy) new V2Mapper(_logger) : new V1Mapper(_logger);
 
             if (_mappingStrategy.GetType() != nextStrategy.GetType())
             {
                 _logger.LogInformation($"Detected differing strategy, changing from {_mappingStrategy.GetType()} to {nextStrategy.GetType()}");
                 _mappingStrategy = nextStrategy;
             }
             _mappingStrategy.handleOSCMessage(msg);
+            _mappingStrategy.UpdateVRCFTEyeData(ref UnifiedTracking.Data.Eye, ref UnifiedTracking.Data.Shapes);
         }
 
         private bool IsV2Param(OSCMessage oscMessage)
@@ -36,10 +37,5 @@ private bool IsV2Param(OSCMessage oscMessage)
             _logger.LogInformation($"is V2 param: {isv2Param.ToString()}");
             return isv2Param;
         }
-
-        public void UpdateVRCFTEyeData()
-        {
-            _mappingStrategy.UpdateVRCFTEyeData(ref UnifiedTracking.Data.Eye, ref UnifiedTracking.Data.Shapes);
-        }
     }
 }