Skip to content

fix(setup): fix instruction and port checking for Linux - #38

Merged
lorow merged 1 commit into
EyeTrackVR:mainfrom
nponsard:fix/linux-setup
Jul 19, 2026
Merged

fix(setup): fix instruction and port checking for Linux#38
lorow merged 1 commit into
EyeTrackVR:mainfrom
nponsard:fix/linux-setup

Conversation

@nponsard

@nponsard nponsard commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Using backslashes for paths doesn't work on Unix, also the script was refusing any port that wasn't starting with COM, changed it to check for COM on windows and /dev/tty on everything else.

@nponsard
nponsard force-pushed the fix/linux-setup branch 3 times, most recently from ecb0c50 to bd77a15 Compare July 9, 2026 18:33
Signed-off-by: Nils Ponsard <nilsponsard@gmail.com>

@lorow lorow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much!

I'll try and get the changes merged tomorrow!

@lorow
lorow merged commit ce96c28 into EyeTrackVR:main Jul 19, 2026
30 checks passed
@nponsard
nponsard deleted the fix/linux-setup branch July 19, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants