Commit 72a255d
dpdk-spec-leader
docs(spec): revise dpdk-23-24 spec — 4 patches via user KNI feedback (3->4)
Revision (v0.2) of the dpdk_23_24_upgrade spec set, triggered by user
feedback at 2026-06-09 14:50 on KNI handling. Two key corrections:
(1) F-Stack 'KNI' truth (lib/Makefile:34 + lib/ff_dpdk_kni.c implementation):
- F-Stack's FF_KNI is a ring + virtio_user user-space exception path,
NOT dependent on DPDK librte_kni or rte_kni.ko. lib/Makefile:34 says
explicitly 'No DPDK KNI support on FreeBSD' / 'Enable KNI, via virtio
only, no longer support rte_kni.ko'. grep rte_kni in lib/ff_dpdk_kni.c
yields 0 hits. nm libfstack.a yields 0 rte_kni symbols.
- Consequence: keep FF_KNI=1; dpdk/ ends up with only igb_uio as the
single kernel module (24.11.6 upstream lacks lib/kni and kernel/linux/kni
anyway, plus 29c7d58 deletion patch keeps it that way).
- v0.1's R-D2 'KNI removed in 24.11 P1 risk' downgraded to N/A.
- v0.1's Must-Fix-1 'KNI A/B decision' cancelled.
(2) patch-scout v1 missed identification of 29c7d58:
Originally reported 'F-Stack local DPDK patches = 3 commits, no
omissions, empty differential set' was based on 'diff -rq | head -25'
truncated output. Full re-measurement (no head, plus
'git log --diff-filter=D') uncovers a fourth commit:
- 29c7d58 (2025-01-10) 'Remove redundant dpdk files' — DELETE 310
files / -43195 lines (KNI subtree + old igb_uio + liquidio + acc200 +
nfp + idpf + flow_classify + Windows EAL log + ...).
Patch list updated 3 -> 4 across all spec docs. Per plan.md §4.4 + DP-A8,
the 4 patches still merge into a single 'port:' commit during M3.
Files modified (v0.1 -> v0.2):
00-overview-and-glossary.md (142 -> 143 lines)
§5.1 patch table: 3 rows -> 4 rows; added 29c7d58 row at top
01-requirements-spec.md (154 -> 154 lines)
§6 R-D2 row rewritten as N/A
§7.2 DP-B2 row rewritten as N/A with KNI truth note
02-current-and-target.md (290 -> 358 lines)
§2 added '4 patches' framing + scout-missed-identification note
§2.4 NEW: full 29c7d58 description + 310 file delete classification
§2.5 NEW: 4-patch overview table
§2.6 (was §2.4) F-Stack 0-ref new lib note
§3.6 KNI status section completely rewritten with three evidence
chains (Makefile comment, grep rte_kni 0 hits, libfstack.a nm)
04-port-and-impl.md (490 -> 527 lines)
§3.2 M2 step: format-patch list 3 -> 4 (29c7d58 added as 0001)
§3.3 M2-AC4 'patches落档' threshold 3 -> 4
§3.4 M2-R2 KNI risk row marked closed (struck through)
§M2 commit message template: patch list 3 -> 4
§4 M3 title '3 patch -> 4 patch'
§4.2.0 NEW: 29c7d58 re-application step
§4.2.5 commit message template rewritten with 4-patch list + KNI clarification
§4.3 ACs added M3-AC4 (KNI subtree absent verification) + M3-AC5
(igb_uio subtree present verification)
§4.4 risks updated (M3-R2/R3 split for 29c7d58 N/A and rename)
§8.2 commit form summary: '3 patch' -> '4 patch'
99-review-report.md (238 -> 392 lines)
Bumped to v0.2; added v0.2 revision-record block at top
§0 conclusion: PASS still; revisions noted
§1 KNI truth + 29c7d58 mis-identification + igb_uio timeline paradox
§6.1 Must-Fix-1 cancelled (struck through)
§6.2 added Nice-4, Nice-5
Backed up to dpdk-stable-24.11.6/f-stack-lib/test-configs/dpdk-23-24-upgrade/.
Total spec lines: 2169 (v0.1) -> 2420 (v0.2; plan.md included as
.gitignored local-only artifact at 461 lines).
Workspace mandate: 0 direct rm/kill/chmod throughout. Local commit only;
no push (per project standing convention).1 parent d25ba1e commit 72a255d
5 files changed
Lines changed: 311 additions & 60 deletions
File tree
- docs/dpdk_23_24_upgrade_spec/zh_cn
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
Lines changed: 73 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
117 | 157 | | |
118 | 158 | | |
119 | 159 | | |
| |||
191 | 231 | | |
192 | 232 | | |
193 | 233 | | |
194 | | - | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
195 | 250 | | |
196 | | - | |
| 251 | + | |
197 | 252 | | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
206 | 265 | | |
207 | 266 | | |
208 | 267 | | |
| |||
0 commit comments