fix(core): clean up unsplit rebase regressions

Author: F0RLE

src-tauri/src/domain/modules/controller/lifecycle.rs

@@ -337,6 +337,7 @@ impl<'a> LifecycleExecutor<'a> {
         let lifecycle_lock = module_lifecycle_lock(&self.module_id).await;
         let _lifecycle_guard = lifecycle_lock.lock().await;
         tracing::info!("Stopping module: {}", self.module_id);
+        let script_entry_path = self.resolve_script_entry_path(manifest)?;
 
         // 1. Run stop script if exists
         if let Some(stop_cmd) = manifest.lifecycle.as_ref().and_then(|l| l.stop.clone()) {
@@ -441,11 +442,6 @@ impl<'a> LifecycleExecutor<'a> {
             tokio::time::sleep(Duration::from_millis(500)).await;
         }
 
-        let script_entry_path = self.resolve_script_entry_path(manifest)?;
-        if let Some(entry_path) = script_entry_path.as_ref() {
-            self.kill_matching_script_processes(entry_path).await?;
-        }
-
         if self
             .controller
             .is_running(&self.module_id, self.module_path)

src/features/chat/chat.test.ts

@@ -318,7 +318,7 @@ describe('ChatController', () => {
             _state: { isSending: boolean };
         };
 
-        controller.init();
+        const initPromise = controller.init();
         internals._state.isSending = true;
         resolvePreview({
             data_url: 'data:image/png;base64,abc',
@@ -329,6 +329,7 @@ describe('ChatController', () => {
             speed: null,
             eta_relative: null,
         });
+        await initPromise;
         await Promise.resolve();
         await Promise.resolve();
 

src/features/chat/controllers/ChatSendController.ts

@@ -179,7 +179,6 @@ export class ChatSendController {
 
         let streamingHandle: StreamingMessageHandle | null = null;
         let imageHandle: ImageGenerationHandle | null = null;
-        let streamingHandle: StreamingMessageHandle | null = null;
         let shouldStopImageEngine = false;
 
         try {

src/features/settings/ui/ModuleSettingsEngineRenderFlow.ts

@@ -213,38 +213,4 @@ export class ModuleSettingsEngineRenderFlow {
             options.config,
         );
     }
-
-    private _renderTextFields(options: {
-        container: HTMLElement;
-        appId: string;
-        config: EngineConfig | null;
-        translate: TranslateFn;
-        getTextFields: ModuleSettingsEngineRenderOptions['getTextFields'];
-    }): void {
-        const fieldTargets: Record<string, string> = {
-            context_size: `#local-engine-context-${options.appId}`,
-            llamacpp_system_prompt: `#local-engine-system-prompt-${options.appId}`,
-        };
-
-        options.getTextFields(options.translate).forEach((field) => {
-            const targetSelector = fieldTargets[field.key];
-            if (targetSelector === undefined) {
-                // eslint-disable-next-line no-console
-                console.warn(
-                    `[ModuleSettingsEngineRenderFlow] Missing target for text field "${field.key}" in ${options.appId}`,
-                );
-                return;
-            }
-            const target = options.container.querySelector(targetSelector);
-            if (!(target instanceof HTMLElement)) {
-                return;
-            }
-
-            this._deps.renderFieldRow(target, {
-                ...field,
-                appId: options.appId,
-                config: options.config,
-            });
-        });
-    }
 }

src/infrastructure/tauri/TauriProvider.test.ts

@@ -43,12 +43,22 @@ function setupWebMode(): {
     win: Record<string, unknown>;
     origInternals: unknown;
     provider: TauriProvider;
+    openExternal: ReturnType<typeof vi.fn>;
 } {
     const win = globalThis as unknown as Record<string, unknown>;
     const origInternals = win['__TAURI_INTERNALS__'];
     delete win['__TAURI_INTERNALS__'];
+    const openExternal = vi.fn();
 
-    return { win, origInternals, provider: new TauriProvider(createTracer()) };
+    return {
+        win,
+        origInternals,
+        openExternal,
+        provider: new TauriProvider(createTracer(), {
+            hasTauriGlobals: () => false,
+            openExternal,
+        }),
+    };
 }
 
 import { TauriProvider } from '@/infrastructure/tauri/TauriProvider';
@@ -413,12 +423,11 @@ describe('TauriProvider', () => {
             await expect(provider.writeToClipboard('copied text')).rejects.toThrow('denied');
         });
 
-        it('should reject in web mode', async () => {
+        it('should use browser clipboard fallback in web mode', async () => {
             const { provider: webProvider } = setupWebMode();
 
-            await expect(webProvider.writeToClipboard('text')).rejects.toThrow(
-                'Clipboard write is unavailable outside Tauri',
-            );
+            await expect(webProvider.writeToClipboard('text')).resolves.toBeUndefined();
+            expect(mockedTauriInvoke).not.toHaveBeenCalled();
         });
     });
 
@@ -461,12 +470,11 @@ describe('TauriProvider', () => {
             });
         });
 
-        it('should reject outside Tauri', async () => {
-            const { provider: webProvider } = setupWebMode();
+        it('should use the runtime fallback outside Tauri', async () => {
+            const { provider: webProvider, openExternal } = setupWebMode();
 
-            await expect(webProvider.openUrl('https://example.com')).rejects.toThrow(
-                'External URL opening is unavailable outside Tauri',
-            );
+            await expect(webProvider.openUrl('https://example.com')).resolves.toBeUndefined();
+            expect(openExternal).toHaveBeenCalledWith('https://example.com');
         });
     });