Issue #1487 - Fix issue with Node FQDN required parameters (#1492)

* Issue #1487 - Fix issue with Node FQDN required parameters

Problem: SDK requires address parameter with Node, but the REST API
does not require it for fqdn type nodes

Solution: This PR looks for a set of required parameters that exclusively
permits the fqdn or the address for the create method.

Files Changed:

- f5/bigip/tm/ltm/node.py (changed)
- f5/bigip/tm/ltm/test/functional/test_node.py (changed)

* Issue #1487 - removed pytest-xdist as test requirement

Author: f5-rahm

f5/bigip/tm/ltm/node.py

@@ -31,6 +31,8 @@
 from f5.bigip.resource import Resource
 from f5.bigip.resource import Stats
 from f5.sdk_exception import NodeStateModifyUnsupported
+from f5.sdk_exception import RequiredOneOf
+from six import iterkeys
 
 
 class Nodes(Collection):
@@ -47,12 +49,22 @@ class Node(Resource):
     def __init__(self, nodes):
         super(Node, self).__init__(nodes)
         self._meta_data['required_json_kind'] = 'tm:ltm:node:nodestate'
-        self._meta_data['required_creation_parameters'].update(
-            ('partition', 'address',)
-        )
+        self._meta_data['required_creation_parameters'] = set()
         self._meta_data['read_only_attributes'].append('ephemeral')
         self._meta_data['read_only_attributes'].append('address')
 
+    def create(self, **kwargs):
+        required_one_of = [
+            ['name', 'address'],
+            ['name', 'fqdn']
+        ]
+        args = set(iterkeys(kwargs))
+        has_any = [set(x).issubset(args) for x in required_one_of]
+        if len([x for x in has_any if x is True]) == 1:
+            return self._create(**kwargs)
+
+        raise RequiredOneOf(required_one_of)
+
     def update(self, **kwargs):
         """Call this to change the configuration of the service on the device.
 

f5/bigip/tm/ltm/test/functional/test_node.py

@@ -15,8 +15,8 @@
 
 import pytest
 
-from f5.sdk_exception import MissingRequiredCreationParameter
 from f5.sdk_exception import NodeStateModifyUnsupported
+from f5.sdk_exception import RequiredOneOf
 
 
 TESTDESCRIPTION = "TESTDESCRIPTION"
@@ -40,7 +40,7 @@ def teardown():
 class TestNode(object):
     def test_create_missing_args(self, mgmt_root):
         n1 = mgmt_root.tm.ltm.nodes.node
-        with pytest.raises(MissingRequiredCreationParameter):
+        with pytest.raises(RequiredOneOf):
             n1.create(name="n1", partition='Common')
 
     def test_CURDLE(self, request, mgmt_root):

requirements.test.txt

@@ -11,7 +11,6 @@ pyOpenSSL==16.2.0
 requests-mock==1.2.0
 netaddr
 q
-pytest-xdist
 pycodestyle
 jinja2
 tox