Skip to content

Commit a334562

Browse files
Rayn93Rayn93
committed
FFWEB-3412: Support tab navigation
Support tab navigation for search, suggest and paging components
1 parent d72b335 commit a334562

3 files changed

Lines changed: 27 additions & 24 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22
## Unreleased
3+
### Change
4+
- Support tab navigation for search, suggest and paging components
5+
36
### Fix
47
- Cart tracking - parse price to float
58

‎src/view/frontend/templates/ff/paging.phtml‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
1111
</ff-paging-item>
1212

13-
<ff-paging-item type="currentLink -2">{{page}}</ff-paging-item>
14-
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
15-
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
16-
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
17-
<ff-paging-item type="currentLink +2">{{page}}</ff-paging-item>
13+
<ff-paging-item type="currentLink -2"><a href="#">{{page}}</a></ff-paging-item>
14+
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
15+
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
16+
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
17+
<ff-paging-item type="currentLink +2"><a href="#">{{page}}</a></ff-paging-item>
1818
<ff-paging-item type="nextLink">
1919
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
2020
</ff-paging-item>
@@ -25,12 +25,12 @@
2525
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
2626
</ff-paging-item>
2727

28-
<ff-paging-item type="currentLink -2">{{value}}</ff-paging-item>
29-
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
30-
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
31-
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
28+
<ff-paging-item type="currentLink -2"><a href="#">{{value}}</a></ff-paging-item>
29+
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
30+
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
31+
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
3232
...
33-
<ff-paging-item type="lastLink">{{page}}</ff-paging-item>
33+
<ff-paging-item type="lastLink"><a href="#">{{page}}</a></ff-paging-item>
3434
<ff-paging-item type="nextLink">
3535
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
3636
</ff-paging-item>
@@ -41,13 +41,13 @@
4141
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
4242
</ff-paging-item>
4343

44-
<ff-paging-item type="firstLink">{{page}}</ff-paging-item>
44+
<ff-paging-item type="firstLink"><a href="#">{{page}}</a></ff-paging-item>
4545
...
46-
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
47-
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
48-
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
46+
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
47+
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
48+
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
4949
...
50-
<ff-paging-item type="lastLink">{{page}}</ff-paging-item>
50+
<ff-paging-item type="lastLink"><a href="#">{{page}}</a></ff-paging-item>
5151

5252
<ff-paging-item type="nextLink">
5353
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">
@@ -58,12 +58,12 @@
5858
<ff-paging-item type="previousLink">
5959
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_prev_page.png')) ?>">
6060
</ff-paging-item>
61-
<ff-paging-item type="firstLink">{{page}}</ff-paging-item>
61+
<ff-paging-item type="firstLink"><a href="#">{{page}}</a></ff-paging-item>
6262
...
63-
<ff-paging-item type="currentLink -1">{{page}}</ff-paging-item>
64-
<ff-paging-item type="currentLink" style="font-weight: bold;">{{page}}</ff-paging-item>
65-
<ff-paging-item type="currentLink +1">{{page}}</ff-paging-item>
66-
<ff-paging-item type="currentLink +2">{{page}}</ff-paging-item>
63+
<ff-paging-item type="currentLink -1"><a href="#">{{page}}</a></ff-paging-item>
64+
<ff-paging-item type="currentLink" style="font-weight: bold;"><a href="#">{{page}}</a></ff-paging-item>
65+
<ff-paging-item type="currentLink +1"><a href="#">{{page}}</a></ff-paging-item>
66+
<ff-paging-item type="currentLink +2"><a href="#">{{page}}</a></ff-paging-item>
6767

6868
<ff-paging-item type="nextLink">
6969
<input type="image" class="padd" src="<?= $escaper->escapeUrl($block->getViewFileUrl('Omikron_Factfinder::images/paging_next_page.png')) ?>">

‎src/view/frontend/templates/ff/suggest.phtml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,21 @@
1313
<div data-container="searchTerm">
1414
<p class="containerCaption"><?= $escaper->escapeHtml(__('Search suggestions')) ?></p>
1515
<ff-suggest-item type="searchTerm">
16-
<span>{{{name}}}</span>
16+
<a href="#">{{{name}}}</a>
1717
</ff-suggest-item>
1818
</div>
1919

2020
<div data-container="category">
2121
<p class="containerCaption"><?= $escaper->escapeHtml(__('Category suggestions')) ?></p>
2222
<ff-suggest-item type="category">
23-
<span>{{{name}}}</span>
23+
<a href="#">{{{name}}}</a>
2424
</ff-suggest-item>
2525
</div>
2626

2727
<div data-container="brand">
2828
<p class="containerCaption"><?= $escaper->escapeHtml(__('Brands')) ?></p>
2929
<ff-suggest-item type="brand">
30-
<span>{{{name}}}</span>
30+
<a href="#">{{{name}}}</a>
3131
</ff-suggest-item>
3232
</div>
3333
</section>
@@ -38,7 +38,7 @@
3838
<ff-suggest-item type="productName">
3939
<img data-image="{{suggestions.image}}" />
4040
<div class="product-center">
41-
<div class="product-name">{{{name}}}</div>
41+
<a href="#" class="product-name">{{{name}}}</a>
4242
</div>
4343
<div class="product-right">
4444
<div class="product-price">{{attributes.Price}}</div>

0 commit comments

Comments
 (0)