Add logging for slow http requests

The threshold is 1s by default and can be configured.

Author: Brutus5000

src/main/java/com/faforever/api/config/FafApiProperties.java

@@ -39,6 +39,7 @@ public class FafApiProperties {
   private Tutorial tutorial = new Tutorial();
   private Nodebb nodebb = new Nodebb();
   private Recaptcha recaptcha = new Recaptcha();
+  private Monitoring monitoring = new Monitoring();
 
   @Data
   public static class OAuth2 {
@@ -267,4 +268,9 @@ public static class Recaptcha {
     private boolean enabled;
     private String secret;
   }
+
+  @Data
+  public static class Monitoring {
+    private double slowRequestThresholdSeconds = 1.0;
+  }
 }

src/main/java/com/faforever/api/logging/RequestIdFilter.java

@@ -9,7 +9,6 @@
 
 import javax.servlet.Filter;
 import javax.servlet.FilterChain;
-import javax.servlet.FilterConfig;
 import javax.servlet.ServletException;
 import javax.servlet.ServletRequest;
 import javax.servlet.ServletResponse;
@@ -34,16 +33,11 @@ public class RequestIdFilter implements Filter {
    */
   private static final String REQUEST_ID_HEADER = "X-Request-ID";
 
-  @Override
-  public void init(FilterConfig filterConfig) {
-  }
-
   @Override
   public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
     String requestId = null;
 
-    if (request instanceof HttpServletRequest) {
-      HttpServletRequest httpRequest = (HttpServletRequest) request;
+    if (request instanceof HttpServletRequest httpRequest) {
       requestId = httpRequest.getHeader(REQUEST_ID_HEADER);
     }
 
@@ -65,8 +59,4 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
     }
   }
 
-  @Override
-  public void destroy() {
-  }
-
 }

src/main/java/com/faforever/api/logging/SlowRequestDetectionFilter.java

@@ -0,0 +1,54 @@
+package com.faforever.api.logging;
+
+import com.faforever.api.config.FafApiProperties;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.stereotype.Component;
+import org.springframework.util.StopWatch;
+import org.springframework.util.StringUtils;
+
+import javax.servlet.Filter;
+import javax.servlet.FilterChain;
+import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServletRequest;
+import java.io.IOException;
+
+/**
+ * This logging interceptor checks for slow http calls and logs the whole request url.
+ */
+@Component
+@Slf4j
+@RequiredArgsConstructor
+public class SlowRequestDetectionFilter implements Filter {
+
+  private final FafApiProperties properties;
+
+  @Override
+  public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
+    StopWatch stopWatch = new StopWatch();
+    log.trace("Start stopwatch for performance measuring");
+    stopWatch.start();
+
+    try {
+      chain.doFilter(request, response);
+    } finally {
+      stopWatch.stop();
+      log.trace("Stop stopwatch for performance measuring, total time: {}", stopWatch.getTotalTimeSeconds());
+
+      if (request instanceof HttpServletRequest httpRequest &&
+        stopWatch.getTotalTimeSeconds() > properties.getMonitoring().getSlowRequestThresholdSeconds()) {
+        StringBuffer urlBuffer = httpRequest.getRequestURL();
+
+        if (StringUtils.hasText(httpRequest.getQueryString())) {
+          urlBuffer.append("?");
+          urlBuffer.append(httpRequest.getQueryString());
+        }
+
+        log.warn("Slow request detected: {} seconds @ {}", stopWatch.getTotalTimeSeconds(), urlBuffer.toString());
+      }
+    }
+  }
+
+}

src/test/java/com/faforever/api/deployment/ExeUploaderControllerTest.java

@@ -36,6 +36,8 @@ public class ExeUploaderControllerTest {
   private FafApiProperties fafApiProperties;
   @MockBean
   private FafApiProperties.Deployment deployment;
+  @MockBean
+  private FafApiProperties.Monitoring monitoring;
 
   @Mock
   private MockMultipartFile file;
@@ -48,8 +50,10 @@ public void init(MockMvc mvc) {
   @BeforeEach
   public void setUp() {
     when(fafApiProperties.getDeployment()).thenReturn(deployment);
+    when(fafApiProperties.getMonitoring()).thenReturn(monitoring);
     when(deployment.getAllowedExeExtension()).thenReturn("exe");
     when(deployment.getTestingExeUploadKey()).thenReturn(API_KEY);
+    when(monitoring.getSlowRequestThresholdSeconds()).thenReturn(1.0);
     file = new MockMultipartFile("file",
       "ForgedAlliance.exe",
       "application/octet-stream",